Puppy Linux Discussion Forum Forum Index Puppy Linux Discussion Forum
Puppy HOME page : puppylinux.com
"THE" alternative forum : puppylinux.info
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

The time now is Sat 13 Feb 2016, 07:10
All times are UTC - 4
 Forum index » Advanced Topics » Additional Software (PETs, n' stuff) » System
Revert rox-filer to auto prompt if copy is overwrite
Post new topic   Reply to topic View previous topic :: View next topic
Page 1 of 1 [14 Posts]  
Author Message
gyro

Joined: 28 Oct 2008
Posts: 982
Location: Brisbane, Australia

PostPosted: Mon 19 Jan 2015, 15:30    Post subject:  Revert rox-filer to auto prompt if copy is overwrite  

The latest 'rox-filer' no longer supports the automatic displaying of a confirmation dialog if a copy operation involves overwriting the target.
This pet contains a version of 'rox-filer' that does.

It's the current version of 'rox-filer' compiled on tahrpup 6.0.1, with the following 2 patches applied:
Code:
--- action.orig.c   2014-11-29 22:28:51.000000000 +1000
+++ action.c   2015-01-15 00:46:41.220558669 +1000
@@ -1338,7 +1338,7 @@
       {
          printf_send("<%s", path);
          printf_send(">%s", dest_path);
-         if (!printf_reply(from_parent, merge,
+         if (!printf_reply(from_parent, TRUE,
                  _("?'%s' already exists - %s?"),
                  dest_path,
                  merge ? _("merge contents")
and
Code:
--- main.orig.c   2014-11-29 22:28:51.000000000 +1000
+++ main.c   2015-01-15 01:42:25.239573589 +1000
@@ -526,7 +526,7 @@
 
    tooltips = gtk_tooltips_new();
 
-   if (euid == 0 || show_user)
+   if (show_user)
       show_user_message = g_strdup_printf(_("Running as user '%s'"),
                       user_name(euid));
    
Unfortunately this also means that the "Quiet" button in the copy confirmation dialog, reverts to not working.

So if your puppy includes the latest 'rox-filer', as tahrpup 6.0.1 does, then you can do nothing and have a working "Quiet" button and no automatic prompt on overwrite. Or apply this pet and have automatic prompt on overwrite, but a non working "Quiet" button.

The pet is 257K, too big to attach, so download it from here http://www.fishprogs.info/puppy/rox-filer-revert-1.0.pet.

gyro
Back to top
View user's profile Send private message 
MochiMoppel


Joined: 26 Jan 2011
Posts: 904
Location: Japan

PostPosted: Tue 20 Jan 2015, 21:29    Post subject: Re: Revert rox-filer to auto prompt if copy is overwrite  

gyro wrote:
The latest 'rox-filer' no longer supports the automatic displaying of a confirmation dialog if a copy operation involves overwriting the target.
???
The latest ROX-Filer seems to work as intended. In the Options menu unselect Action windows > Autostart [ ] copy.
This will trigger the confirmation dialog with a working (!) Quiet button. The bad news: This will trigger the dialog even when no overwriting is involved. ROX has no dedicated "confirm overwrites" dialog, it's rather "confirm all copy operations" or "never ask".
Back to top
View user's profile Send private message 
gyro

Joined: 28 Oct 2008
Posts: 982
Location: Brisbane, Australia

PostPosted: Wed 21 Jan 2015, 01:40    Post subject:  

@MochiMoppel,
This reverts 'rox-filer' to the way it used to be:
Confirm copy dialog only appears if the copy results in an overwrite, but 'Quiet' button doesn't work.

If you prefer the new way, do nothing.
If you prefer the old way, apply this pet.

gyro
Back to top
View user's profile Send private message 
MochiMoppel


Joined: 26 Jan 2011
Posts: 904
Location: Japan

PostPosted: Wed 21 Jan 2015, 03:19    Post subject:  

removed

(I had the impression that the copy behaviour was the only difference between the ROX-Filers in 6.0 in 6.0.1 service-pack, which wouldn't need an extra pet to fix, but there are probably other exciting new features in the newest version...)
Back to top
View user's profile Send private message 
gyro

Joined: 28 Oct 2008
Posts: 982
Location: Brisbane, Australia

PostPosted: Wed 21 Jan 2015, 07:06    Post subject:  

MochiMoppel wrote:
(I had the impression that the copy behaviour was the only difference between the ROX-Filers in 6.0 in 6.0.1 service-pack, which wouldn't need an extra pet to fix, but there are probably other exciting new features in the newest version...)
This pet is all about the copy behaviour, I've no idea if there are any other exciting new features.
I created the pet because I assume that a new tahrpup iso will not contain a 'ROX-Filer' that supports the old copy behaviour. So the only way to revert will be by introducing a patched version of 'ROX-Filer'.

gyro
Back to top
View user's profile Send private message 
MochiMoppel


Joined: 26 Jan 2011
Posts: 904
Location: Japan

PostPosted: Wed 21 Jan 2015, 07:27    Post subject:  

gyro wrote:
I created the pet because I assume that a new tahrpup iso will not contain a 'ROX-Filer' that supports the old copy behaviour.
Which makes it a preemptive patch to reintroduce an officially acknowledged and finally fixed bug Laughing

Seriously: Do you think many people will miss the old buggy behaviour? Though I like some bugs which I would miss if anyone dares to fix them, this wasn't one of them.
Back to top
View user's profile Send private message 
SFR


Joined: 26 Oct 2011
Posts: 1399

PostPosted: Wed 21 Jan 2015, 08:41    Post subject:  

MochiMoppel wrote:
Do you think many people will miss the old buggy behaviour?

me@http://www.murga-linux.com/puppy/viewtopic.php?p=792147#792147 wrote:
Anyway, I'm curious what others think about it?
On the other thread 666philb and Stemsee were rather enthusiastic, so let's say we have 3-1 for "overwrite" at the moment.

So now, with Gyro, we have 3-2. Wink

gyro wrote:
I've no idea if there are any other exciting new features

Most of all: "Fixed xdgmime support for zero-length files" - before this fix entering /proc dir with thumbnails turned on used to cause total hang of ROX.

Greetings!

_________________
[O]bdurate [R]ules [D]estroy [E]nthusiastic [R]ebels => [C]reative [H]umans [A]lways [O]pen [S]ource
Omnia mea mecum porto.
Back to top
View user's profile Send private message 
gyro

Joined: 28 Oct 2008
Posts: 982
Location: Brisbane, Australia

PostPosted: Wed 21 Jan 2015, 08:43    Post subject:  

MochiMoppel wrote:
Seriously: Do you think many people will miss the old buggy behaviour?
If there is anyone who does, then this pet gives them an option to get it back.
gyro
Back to top
View user's profile Send private message 
gyro

Joined: 28 Oct 2008
Posts: 982
Location: Brisbane, Australia

PostPosted: Wed 21 Jan 2015, 08:49    Post subject:  

I did this for my own installation of Tahrpup 6, and I may even to do it again if needed. If this becomes a long term pain, I'll be investigating alternate file managers.

I share the pet here just in case there is anyone else who thinks the old buggy way is preferable to the new way.

Note: According to the "ROX-Filer" git, the new way is a bug fix.
My first patch is a direct reversal of the official patch.

gyro

Last edited by gyro on Wed 21 Jan 2015, 09:24; edited 1 time in total
Back to top
View user's profile Send private message 
gyro

Joined: 28 Oct 2008
Posts: 982
Location: Brisbane, Australia

PostPosted: Wed 21 Jan 2015, 09:20    Post subject:  

@SFR
I was not aware that you had produced a most likely superior pet in this other topic. I just wanted my familiar 'ROX-Filer' back, in Tahrpup 6.0.1.
gyro
Back to top
View user's profile Send private message 
gyro

Joined: 28 Oct 2008
Posts: 982
Location: Brisbane, Australia

PostPosted: Mon 23 Feb 2015, 10:04    Post subject: Dead-end  

I now consider this project to be a dead-end, since the unacceptable behaviour of Rox-Filer is considered to be a feature, not a bug.

I've moved on to http://www.murga-linux.com/puppy/viewtopic.php?t=97469

gyro
Back to top
View user's profile Send private message 
miriam


Joined: 06 Dec 2006
Posts: 287
Location: Queensland, Australia

PostPosted: Wed 03 Feb 2016, 23:35    Post subject:  

Thanks gyro, I just installed tahrpup and was copying some of my old files onto the new installation and noticed with great alarm that it blithely went ahead, silently overwriting existing files. When I went into the Rox options I unticked autostart (quiet) copy, but then, as you say it became a major pain to copy any great number of files because it now asked for every single file.

I do like the new behavior of correctly recognising zero-length files though. I previously was able to have my cake and eat it too, as someone posted a patch to allow old Rox to recognise them. I'll see if I can find it and post the link here.

_________________
A life! Cool! Where can I download one of those from?
Back to top
View user's profile Send private message Visit poster's website 
MochiMoppel


Joined: 26 Jan 2011
Posts: 904
Location: Japan

PostPosted: Thu 04 Feb 2016, 01:33    Post subject:  

Removed
(SFR's previous post answered my question re. zero-length file bug)
 
 
 

Last edited by MochiMoppel on Thu 04 Feb 2016, 07:33; edited 1 time in total
Back to top
View user's profile Send private message 
greengeek

Joined: 20 Jul 2010
Posts: 3579
Location: New Zealand

PostPosted: Thu 04 Feb 2016, 05:06    Post subject:  

SFR wrote:
So now, with Gyro, we have 3-2.
It is possible that I am misunderstanding this 'bug' - but I never want any "quiet" overwriting. I prefer to be prompted to overwrite each file. If there is to be any extensive overwriting I will first remove the previous versions (assuming I have some idea of what I am attempting to do, which is not always the case Smile )
Back to top
View user's profile Send private message 
Display posts from previous:   Sort by:   
Page 1 of 1 [14 Posts]  
Post new topic   Reply to topic View previous topic :: View next topic
 Forum index » Advanced Topics » Additional Software (PETs, n' stuff) » System
Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Powered by phpBB © 2001, 2005 phpBB Group
[ Time: 0.0536s ][ Queries: 11 (0.0083s) ][ GZIP on ]