pup-volume-monitor-0.1.15 and desktop-drive-icons-0.0.6

Core libraries and systems
Post Reply
Message
Author
akash_rawal
Posts: 229
Joined: Wed 25 Aug 2010, 15:38
Location: ISM Dhanbad, Jharkhand, India

#16 Post by akash_rawal »

Jejy69 wrote: I do not know if you've had this bug, but I unfortunately can not delete some folders. It returns me an error message:
"Invalid cross-device link".
My Thunar is 1.4.
On updating thunar to 1.4 I get "Invalid argument" instead and that too only sometimes.
It can't be pup-volume-monitor bug as it does not implement any vfs.

User avatar
Jejy69
Posts: 710
Joined: Thu 20 Jan 2011, 18:10
Location: Perpignan

#17 Post by Jejy69 »

Thank you very much for your answer! I will then move to the previous version. :)
I'm Commander Shepard and this is my favorite Linux distrbution on the Citadel.

User avatar
jemimah
Posts: 4307
Joined: Wed 26 Aug 2009, 19:56
Location: Tampa, FL
Contact:

#18 Post by jemimah »

This fixed my laptop with the internal optical drive.

But on my netbook with the USB drive, I can't get the volume monitor to acknowledge the existence of sr0 at all. It doesn't show up if I run "pup-volume-monitor-admin -l". I verified that the drive works fine if I mount it by hand.

Ideas?
[url]http://saluki-linux.com[/url]

akash_rawal
Posts: 229
Joined: Wed 25 Aug 2010, 15:38
Location: ISM Dhanbad, Jharkhand, India

#19 Post by akash_rawal »

jemimah wrote: But on my netbook with the USB drive, I can't get the volume monitor to acknowledge the existence of sr0 at all. It doesn't show up if I run "pup-volume-monitor-admin -l". I verified that the drive works fine if I mount it by hand.
What is the output of udevadm monitor when you plug in the drive?

User avatar
jemimah
Posts: 4307
Joined: Wed 26 Aug 2009, 19:56
Location: Tampa, FL
Contact:

#20 Post by jemimah »

Code: Select all

# udevadm monitor
monitor will print the received events for:
UDEV - the event which udev sends out after rule processing
KERNEL - the kernel uevent

KERNEL[1341316280.050720] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3 (usb)
KERNEL[1341316280.053092] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0 (usb)
KERNEL[1341316280.053629] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3 (scsi)
KERNEL[1341316280.054045] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/scsi_host/host3 (scsi_host)
KERNEL[1341316280.056948] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/usb_device/usbdev1.5 (usb_device)
UDEV  [1341316280.074994] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3 (usb)
UDEV  [1341316280.091578] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/usb_device/usbdev1.5 (usb_device)
UDEV  [1341316280.204800] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0 (usb)
UDEV  [1341316280.215018] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3 (scsi)
UDEV  [1341316280.225889] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/scsi_host/host3 (scsi_host)
KERNEL[1341316281.063576] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0 (scsi)
KERNEL[1341316281.064294] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0/3:0:0:0 (scsi)
UDEV  [1341316281.082122] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0 (scsi)
KERNEL[1341316281.172254] add      /devices/virtual/bdi/11:0 (bdi)
KERNEL[1341316281.177409] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0/3:0:0:0/block/sr0 (block)
KERNEL[1341316281.177638] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0/3:0:0:0/scsi_device/3:0:0:0 (scsi_device)
KERNEL[1341316281.177851] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0/3:0:0:0/bsg/3:0:0:0 (bsg)
UDEV  [1341316281.186419] add      /devices/virtual/bdi/11:0 (bdi)
KERNEL[1341316281.191525] change   /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0/3:0:0:0/block/sr0 (block)
UDEV  [1341316281.229634] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0/3:0:0:0 (scsi)
UDEV  [1341316281.247390] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0/3:0:0:0/scsi_device/3:0:0:0 (scsi_device)
UDEV  [1341316281.269651] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0/3:0:0:0/bsg/3:0:0:0 (bsg)
UDEV  [1341316281.324799] add      /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0/3:0:0:0/block/sr0 (block)
UDEV  [1341316281.335682] change   /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0/3:0:0:0/block/sr0 (block)
KERNEL[1341316290.987391] change   /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0/3:0:0:0/block/sr0 (block)
UDEV  [1341316291.000075] change   /devices/pci0000:00/0000:00:1d.7/usb1/1-3/1-3:1.0/host3/target3:0:0/3:0:0:0/block/sr0 (block)
[url]http://saluki-linux.com[/url]

akash_rawal
Posts: 229
Joined: Wed 25 Aug 2010, 15:38
Location: ISM Dhanbad, Jharkhand, India

#21 Post by akash_rawal »

The output is similar to one I get when I plug in my usb modem which also behaves like an optical drive. Yet when I plug it in, it is detected by the volume monitor and shown.

All I can guess is that /etc/udev/rules.d/50-pup-volume-monitor.rules could have gone missing. Don't know how it happens it has happened to me several times while working with autotools.

User avatar
jemimah
Posts: 4307
Joined: Wed 26 Aug 2009, 19:56
Location: Tampa, FL
Contact:

#22 Post by jemimah »

Udev events from other drives make it through - I can see them with pup-volume-monitor-admin -e.

I've attached the udevd debug log.
Attachments
udevdebug.gz
(4.84 KiB) Downloaded 1073 times
[url]http://saluki-linux.com[/url]

User avatar
jemimah
Posts: 4307
Joined: Wed 26 Aug 2009, 19:56
Location: Tampa, FL
Contact:

#23 Post by jemimah »

It's definitely a packaging problem of some sort. I booted a fresh install on my development machine and it doesn't work with the internal drive there either.

I'll try to figure out what's missing.
[url]http://saluki-linux.com[/url]

akash_rawal
Posts: 229
Joined: Wed 25 Aug 2010, 15:38
Location: ISM Dhanbad, Jharkhand, India

#24 Post by akash_rawal »

Udev events are as expected. But what maybe going wrong is totally unexpected.

I am attaching modified plugins/cdrom.c with debugging code added wherever necessary. Hope it will help with debugging.
Attachments
cdrom.c.gz
.gz extension is fake, rename it to cdrom.c, replace plugins/cdrom.c with it and recompile.
(13.68 KiB) Downloaded 1091 times

User avatar
jemimah
Posts: 4307
Joined: Wed 26 Aug 2009, 19:56
Location: Tampa, FL
Contact:

#25 Post by jemimah »

I'm not seeing the additional debugging output even on the working system. Strange - can't figure out why that would be.
[url]http://saluki-linux.com[/url]

User avatar
jemimah
Posts: 4307
Joined: Wed 26 Aug 2009, 19:56
Location: Tampa, FL
Contact:

#26 Post by jemimah »

I changed the g_degugs to printfs and now I can see output on the working system.

On the nonworking system I get this:

# pup-volume-monitor

Code: Select all

pup-volume-monitor-Message: Config file for plugin libcdrom not found, it will use default settings

(pup-volume-monitor:15730): GModule-CRITICAL **: g_module_symbol: assertion `module != NULL' failed
What's happening here?
[url]http://saluki-linux.com[/url]

User avatar
jemimah
Posts: 4307
Joined: Wed 26 Aug 2009, 19:56
Location: Tampa, FL
Contact:

#27 Post by jemimah »

Ok I think I figured it out. The existence of /usr/lib/pup-volume-monitor/libcdrom.a and/or /usr/lib/pup-volume-monitor/libcdrom.la seems to be crashing it.
[url]http://saluki-linux.com[/url]

akash_rawal
Posts: 229
Joined: Wed 25 Aug 2010, 15:38
Location: ISM Dhanbad, Jharkhand, India

#28 Post by akash_rawal »

Surely cdrom plugin failed to load with some error.

I agree there's a bug ahead leading to a call to g_module_symbol() even after plugin failed to load, but it should have shown the plugin path... :?

Code: Select all

// libpupvm/pupvm-settings.c:117

gboolean pup_vm_plugin_load(GTypeModule *module)
{
	PupVMPlugin *self = PUP_VM_PLUGIN(module);
	g_return_val_if_fail(self->plugin_name && self->plugin_path, FALSE);

	self->module = g_module_open(self->plugin_path, 0);
	if (!self->module)
	{
		g_debug("Module path: %s", self->plugin_path);
	}

	if (module && (! self->initialised))
	{ ...

Edit: I didn't notice g_module_error() earlier. I improved pup_vm_plugin_load() error output and fixed that bug. This will not cause plugin to load correctly but we'd come to know why plugin failed to load.

libpupvm/pupvm-settings.c:117

Code: Select all

gboolean pup_vm_plugin_load(GTypeModule *module)
{
	PupVMPlugin *self = PUP_VM_PLUGIN(module);
	g_return_val_if_fail(self->plugin_name && self->plugin_path, FALSE);

	self->module = g_module_open(self->plugin_path, 0);
	if (!self->module)
	{
		//g_debug("Module path: %s", self->plugin_path);
		g_critical("Plugin %s (path: %s) failed to open: %s",
		           self->plugin_name, self->plugin_path, g_module_error());
	}

	if (self->module && (! self->initialised))
	{
		//Load plugin's config
		self->cfg_file = g_key_file_new();
		pup_load_cfg_file(self->cfg_file, self->plugin_name);
		
		//Run the plugin's init func
		PupVMPluginInit plugin_init_func;

		if (g_module_symbol(self->module, "pup_vm_plugin_init",
		                    (gpointer *) &plugin_init_func))
		{
			plugin_init_func(self);
		}
		
		self->initialised = TRUE;
	}
	
	if (module) return TRUE;
	else return FALSE;
}

akash_rawal
Posts: 229
Joined: Wed 25 Aug 2010, 15:38
Location: ISM Dhanbad, Jharkhand, India

#29 Post by akash_rawal »

jemimah wrote:Ok I think I figured it out. The existence of /usr/lib/pup-volume-monitor/libcdrom.a and/or /usr/lib/pup-volume-monitor/libcdrom.la seems to be crashing it.
Updated to version 0.1.4

Changelog:
  • Now static libraries are filtered out while loading plugins
  • A few minor bug-fixes

User avatar
peebee
Posts: 4370
Joined: Sun 21 Sep 2008, 12:31
Location: Worcestershire, UK
Contact:

#30 Post by peebee »

Hi akash_rawal
The following small test extracted from Frisbee funcs:

Code: Select all

#!/bin/bash
MSG="Please enter the Password."
Xdialog  --title "Frisbee" --password --inputbox "$MSG" 0 0 > /opt/Pwireless-entry 2>&1
when run in check-mate V3 - Puppy latest LXDE desktop !
produces output in /opt/Pwireless-entry
(Xdialog:9249): pup-volume-monitor-WARNING **: Module loaded successfully
0123456789
that contains unwanted warning from pup-volume-monitor in front of the typed password.
Any ideas why this is happening - and how to stop the warning text being produced please? It is stopping Frisbee working correctly on check-mate.
Thanks
PeeBee
ImageLxPup = Puppy + LXDE
Main version used daily: LxPupSc; Assembler of UPups, ScPup & ScPup64, LxPup, LxPupSc & LxPupSc64

akash_rawal
Posts: 229
Joined: Wed 25 Aug 2010, 15:38
Location: ISM Dhanbad, Jharkhand, India

#31 Post by akash_rawal »

peebee wrote: The following small test extracted from Frisbee funcs ... when run in check-mate V3 - Puppy latest LXDE desktop ! produces output in /opt/Pwireless-entry
(Xdialog:9249): pup-volume-monitor-WARNING **: Module loaded successfully
0123456789
that contains unwanted warning from pup-volume-monitor in front of the typed password.
Updated to version 0.1.5

Changelog:
  • Removed the debugging macro that was used to ensure that the volume monitor module was loaded

User avatar
Jejy69
Posts: 710
Joined: Thu 20 Jan 2011, 18:10
Location: Perpignan

#32 Post by Jejy69 »

Yeah !
Frisbee works ! ! ! You're the best! :D
Thank you for being so quick and efficient!

Thank you Peebee too, have reacted so quickly, and found that this did not work! Bravo! "GG" !
All my derived will be able to function!
I'm Commander Shepard and this is my favorite Linux distrbution on the Citadel.

User avatar
peebee
Posts: 4370
Joined: Sun 21 Sep 2008, 12:31
Location: Worcestershire, UK
Contact:

#33 Post by peebee »

akash_rawal wrote:Updated to version 0.1.5
Changelog:
Removed the debugging macro that was used to ensure that the volume monitor module was loaded
Very many thanks - thought it must have to be something like that....
Cheers
peebee
ImageLxPup = Puppy + LXDE
Main version used daily: LxPupSc; Assembler of UPups, ScPup & ScPup64, LxPup, LxPupSc & LxPupSc64

akash_rawal
Posts: 229
Joined: Wed 25 Aug 2010, 15:38
Location: ISM Dhanbad, Jharkhand, India

#34 Post by akash_rawal »

Updated to version 0.1.6

Changelog:
  • Fixed destructor calling in client module, may fix crashing issues with seamonkey (Edit: It works)

Igo AtM
Posts: 25
Joined: Thu 16 Nov 2006, 14:36
Location: UK

Issue with latest ver 1.6

#35 Post by Igo AtM »

Hi
I have been testing/using the volume monitor module since it first started appearing here and am much impressed with it as a initial implementation.
However I have recently uploaded the version 1.6 and I believe it started causing segmentation faults on my system. I have since reverted back to version 1.5 and have no issues.
being an event based issue The fault is some what difficult to pin down and is only ever reported as a simple seg fault. It would seem to occur most often when using a popup resource browser as a file system utility to a foreground app. The program will on change of browser window and subsequent save requests crash the parent window leaving no or little logged cause of the problem.
I am currently using Slacko 5.3.3 with window managers of compiz/openbox/icewm and pcfileman 1-0 and Libfm 1-0. I do not run a full gvfs as this also generated issues when run in competition with your event backend. My machine is a Dell Inspiron 1501 and puppy is run from an external usb hard drive. As I say puppy its self remains stable it is only the requesting app that crashes. Predominately Geany and Firefox but I notice these as I run the programs almost consistently.
I would like to be more specific in terms of logs of the issue but it is some what complicated in that to do so would require effectively disabling my set-up whilst using 1.6

Post Reply