Puppy Linux Discussion Forum Forum Index Puppy Linux Discussion Forum
Puppy HOME page : puppylinux.com
"THE" alternative forum : puppylinux.info
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

The time now is Wed 26 Nov 2014, 11:16
All times are UTC - 4
 Forum index » Advanced Topics » Additional Software (PETs, n' stuff) » System
pup-volume-monitor-0.1.15 and desktop-drive-icons-0.0.6
Post_new_topic   Reply_to_topic View_previous_topic :: View_next_topic
Page 10 of 11 Posts_count   Goto page: Previous 1, 2, 3, ..., 8, 9, 10, 11 Next
Author Message
mikeb


Joined: 23 Nov 2006
Posts: 8696

PostPosted: Sun 06 Jul 2014, 11:10    Post_subject:  

I think the biggest problem with these icons is that either the dev has run away or only chooses to talk to certain people...

mike
Back to top
View user's profile Send_private_message 
SFR


Joined: 26 Oct 2011
Posts: 1101

PostPosted: Sun 06 Jul 2014, 12:26    Post_subject:  

peebee wrote:
p-v-m-0.1.15 seems to have a bit of a problem with this new facility/method of working in that accessing the partition that contains the frugal install displays the save directory contents rather than the partition contents.

I think it's because /etc/mtab (-> /proc/self/mounts) contains:
Quote:
/dev/sda1 /initrd/mnt/dev_save ext4 rw,noatime,data=ordered 0 0
/dev/sda1 /initrd/pupro1 ext4 rw,noatime,data=ordered 0 0

Apparently only the second entry gets picked by pup-volume-monitor, probably in libpupvm/pupvm-monitor.c, lines 388+.
However I don't know C, so can't fix it...

HTH
Greetings!

_________________
[O]bdurate [R]ules [D]estroy [E]nthusiastic [R]ebels => [C]reative [H]umans [A]lways [O]pen [S]ource
Omnia mea mecum porto.
Back to top
View user's profile Send_private_message 
mikeb


Joined: 23 Nov 2006
Posts: 8696

PostPosted: Sun 06 Jul 2014, 13:15    Post_subject:  

/initrd/pupro1
is that where the folder is loaded to as i use pup_rw ?

When I stop bobbing around in the water I could take a look.... like the other fixed scripts it would only need a bit of filtering.

These icons are great (I have as default on Lucid) so perhaps someone could take over support for them.

mike
Back to top
View user's profile Send_private_message 
SFR


Joined: 26 Oct 2011
Posts: 1101

PostPosted: Sun 06 Jul 2014, 13:51    Post_subject:  

Yep, if it's PUPMODE=13. In PUPMODE=12 mtab says:
Quote:
/dev/sda1 /initrd/mnt/dev_save ext4 rw,noatime,data=ordered 0 0
/dev/sda1 /initrd/pup_rw ext4 rw,noatime,data=ordered 0 0

(btw, it was supposed to be pup_ro1, not pupro1, I made a typo)

Greetings!

_________________
[O]bdurate [R]ules [D]estroy [E]nthusiastic [R]ebels => [C]reative [H]umans [A]lways [O]pen [S]ource
Omnia mea mecum porto.
Back to top
View user's profile Send_private_message 
peebee


Joined: 21 Sep 2008
Posts: 1518
Location: Worcestershire, UK

PostPosted: Mon 07 Jul 2014, 04:51    Post_subject:  

I have asked for clarification of the difference in /etc/mtab between a savefile and a savefolder in Slacko6Beta:

http://murga-linux.com/puppy/viewtopic.php?p=787562#787562

_________________
LxPup-14.10 = Puppy + LXDE
Back to top
View user's profile Send_private_message Visit_website 
gyro

Joined: 28 Oct 2008
Posts: 523
Location: Brisbane, Australia

PostPosted: Mon 07 Jul 2014, 10:42    Post_subject:  

The problem is in the subroutine, "void pup_vm_monitor_get_mounts_unlocked(PupVMMonitor *self)".

It expects to get only a single entry for each "f_ent.mnt_fsname", but when a "mount -o bind" is active, as it is with a savefolder, it gets an extra entry for each "mount -o bind". This extra entry has the same "f_ent.mnt_fsname" but a different "f_ent.mnt_dir".
The entry corresponding to the one expected, is the first one, but the current code stores the last one.
So, near the top of the loop it needs to "continue" if it gets an entry whose "f_ent.mnt_fsname" is the same as the previous entry.
Or it could "continue" if the hash table already contains an entry for this "f_ent.mnt_fsname". Maybe something like:
Code:
      entry.devnode = g_strdup(f_ent.mnt_fsname);
      if (g_hash_table_contains(self->mounts, entry.devnode))
         continue;
Or you could try using "g_hash_table_insert ()", instead of "g_hash_table_replace ()".

gyro
Back to top
View user's profile Send_private_message 
SFR


Joined: 26 Oct 2011
Posts: 1101

PostPosted: Mon 07 Jul 2014, 11:36    Post_subject:  

gyro wrote:
Code:
      entry.devnode = g_strdup(f_ent.mnt_fsname);
      if (g_hash_table_contains(self->mounts, entry.devnode))
         continue;

Yep, it's working correctly now, thanks Gyro!
Btw, any idea what can cause this one?

[later]
While poking in the source code I came across daemon/drive-probes.c and its PupVolume *pup_volume_new_from_blkid_cache(blkid_cache cache, const gchar *devnode) function (or whatever it's called in C).

After short investigation:
- old Slacko has only busybox blkid + util-linux-2.21.2-patched_f2fs-i486
- new Slacko has full blkid (util-linux-2.21.2 from slackware repo, but, apparently, it's not patched).

To confirm, I did replace /lib/libblkid.so.* with the one from Slacko-5.7 and indeed, p-v-m was able to recognize f2fs partitions after that.

Greetings!

_________________
[O]bdurate [R]ules [D]estroy [E]nthusiastic [R]ebels => [C]reative [H]umans [A]lways [O]pen [S]ource
Omnia mea mecum porto.
Back to top
View user's profile Send_private_message 
peebee


Joined: 21 Sep 2008
Posts: 1518
Location: Worcestershire, UK

PostPosted: Tue 08 Jul 2014, 12:27    Post_subject:  

gyro wrote:
The problem is in the subroutine, "void pup_vm_monitor_get_mounts_unlocked(PupVMMonitor *self)".

It expects to get only a single entry for each "f_ent.mnt_fsname", but when a "mount -o bind" is active, as it is with a savefolder, it gets an extra entry for each "mount -o bind". This extra entry has the same "f_ent.mnt_fsname" but a different "f_ent.mnt_dir".
The entry corresponding to the one expected, is the first one, but the current code stores the last one.
So, near the top of the loop it needs to "continue" if it gets an entry whose "f_ent.mnt_fsname" is the same as the previous entry.
Or it could "continue" if the hash table already contains an entry for this "f_ent.mnt_fsname". Maybe something like:
Code:
      entry.devnode = g_strdup(f_ent.mnt_fsname);
      if (g_hash_table_contains(self->mounts, entry.devnode))
         continue;
Or you could try using "g_hash_table_insert ()", instead of "g_hash_table_replace ()".

gyro


Excellent #gyro - very many thanks for tracking that down.

I've recompiled p-v-m on Slacko6beta with the patch and both desktop-drive-icons and pcmanfm are now behaving as they should be when accessing the boot partition when a new savefolder is being used.

My only question is - why does my compile which uses the instructions given by akash-rawal in post #1 result in binaries that are at least 4 times bigger than his compiles???

#SFR - many thanks also for the f2fs fix - I haven't tried that one yet but will soon - wonder whether 01micko will include the needed patch in Slacko6?

Great example of puppy teamwork.
Cheers
peebee

_________________
LxPup-14.10 = Puppy + LXDE
Back to top
View user's profile Send_private_message Visit_website 
SFR


Joined: 26 Oct 2011
Posts: 1101

PostPosted: Tue 08 Jul 2014, 14:50    Post_subject:  

peebee wrote:
My only question is - why does my compile which uses the instructions given by akash-rawal in post #1 result in binaries that are at least 4 times bigger than his compiles???

Did you strip them?

Quote:
wonder whether 01micko will include the needed patch in Slacko6?

Haven't tried it yet, but Mick has recompiled it already:
http://distro.ibiblio.org/puppylinux/pet_packages-slacko14.1/util-linux-2.12.2_f2fs-i686.pet

Greetings!

_________________
[O]bdurate [R]ules [D]estroy [E]nthusiastic [R]ebels => [C]reative [H]umans [A]lways [O]pen [S]ource
Omnia mea mecum porto.
Back to top
View user's profile Send_private_message 
peebee


Joined: 21 Sep 2008
Posts: 1518
Location: Worcestershire, UK

PostPosted: Wed 09 Jul 2014, 02:47    Post_subject:  

SFR wrote:
peebee wrote:
My only question is - why does my compile which uses the instructions given by akash-rawal in post #1 result in binaries that are at least 4 times bigger than his compiles???

Did you strip them?

Quote:
wonder whether 01micko will include the needed patch in Slacko6?

Haven't tried it yet, but Mick has recompiled it already:
http://distro.ibiblio.org/puppylinux/pet_packages-slacko14.1/util-linux-2.12.2_f2fs-i686.pet

Greetings!


Stripped - thanks.

util-linux-2.12.2_f2fs-i686.pet fixes the f2fs problem.

Many thanks
peebee

_________________
LxPup-14.10 = Puppy + LXDE
Back to top
View user's profile Send_private_message Visit_website 
mikeb


Joined: 23 Nov 2006
Posts: 8696

PostPosted: Fri 11 Jul 2014, 11:01    Post_subject:  

No notification from forum Sad

ok I dropped PUPMODE=13 years ago (forgot about that pup_ro1 stuff) so not a problem for me as such and a test with save folder gave one working icon.

The only hiccup is it was possible to unmount the drive from the icon (since there are 2 mounts) and after that I was taken to /initrd/pup_rw which makes some sense but was unable to make the original /mnt/sda1 since I assume the icon saw an existing mount still present . In my case in sysinit I make mnt points that match the device rather than /mnt/home though the result is similar.
Not sure if that affects your arrangements....ie can you unmount the pup drive from the icon and what happens after that?

Also a sr0 appeared from nowhere..not sure about that..was testing in qemu and no /dev/sr0 was enabled!

mike
Back to top
View user's profile Send_private_message 
peebee


Joined: 21 Sep 2008
Posts: 1518
Location: Worcestershire, UK

PostPosted: Fri 11 Jul 2014, 18:32    Post_subject: p-v-m for Slacko6  

Here is a version of p-v-m for Slacko6 with gyro's fix for the new savefolder....
pup-volume-monitor-0.1.15-1-i686-slacko6.pet
Description 
pet

 Download 
Filename  pup-volume-monitor-0.1.15-1-i686-slacko6.pet 
Filesize  100.18 KB 
Downloaded  56 Time(s) 

_________________
LxPup-14.10 = Puppy + LXDE
Back to top
View user's profile Send_private_message Visit_website 
SFR


Joined: 26 Oct 2011
Posts: 1101

PostPosted: Sun 13 Jul 2014, 16:48    Post_subject:  

mikeb wrote:
The only hiccup is it was possible to unmount the drive from the icon (since there are 2 mounts) and after that I was taken to /initrd/pup_rw
[snip]
can you unmount the pup drive from the icon and what happens after that?

just checked and nope, I'm not able to unmount home clicking the icon directly and all the right-click options (mount/unmount/eject) are greyed out.
No matter if it was PM 12 or 13 (Slacko-5.9.3).

mikeb wrote:
In my case in sysinit I make mnt points that match the device rather than /mnt/home though the result is similar.

So in your case it's e.g. /mnt/sda1, but "normally" it's /initrd/mnt/dev_save and P-V-M apparently checks for '/initrd/' string:
Code:
      else if (strstr(entry.mntpnt, "/initrd/"))
      {
         entry.flags |= PUP_VOLUME_MNTD_SYSTEM;
      }

Greetings!

_________________
[O]bdurate [R]ules [D]estroy [E]nthusiastic [R]ebels => [C]reative [H]umans [A]lways [O]pen [S]ource
Omnia mea mecum porto.
Back to top
View user's profile Send_private_message 
mikeb


Joined: 23 Nov 2006
Posts: 8696

PostPosted: Mon 14 Jul 2014, 06:07    Post_subject:  

hmm well the /initrd/mnt/pupwhatever is still there... its bind mounted up to /mnt/sda1 rather than symlinked /mnt/home...which would cause a similar reaction to the initial problem in this post.

Thats ok I was checking it was fixed for standard puppies.

Happy drive iconing

Mike

Ps I wonder since you have taken up pup_volume_monitor ..or at least provide fixews....it should get a fresh thread?
Back to top
View user's profile Send_private_message 
peebee


Joined: 21 Sep 2008
Posts: 1518
Location: Worcestershire, UK

PostPosted: Sat 09 Aug 2014, 06:46    Post_subject: p-v-m and tahrpup  

I have compiled a patched version of libgio-2.0.so.0.4000.0 to enable p-v-m to be used on Tahr Puppy 5.8.3 k3.14.11pae

Download from:
https://e-nautia.com/peebee/disk/share/lxpup/libgio-2.0.so.0.4000.0-patched.pet

Patch for complete glib2 package is attached (false .gz). Used source from Linux-from-Scratch.

Cheers
peebee
glib_2.40.0-tahr-090814.patch.gz
Description 
gz

 Download 
Filename  glib_2.40.0-tahr-090814.patch.gz 
Filesize  1.9 KB 
Downloaded  49 Time(s) 

_________________
LxPup-14.10 = Puppy + LXDE
Back to top
View user's profile Send_private_message Visit_website 
Display_posts:   Sort by:   
Page 10 of 11 Posts_count   Goto page: Previous 1, 2, 3, ..., 8, 9, 10, 11 Next
Post_new_topic   Reply_to_topic View_previous_topic :: View_next_topic
 Forum index » Advanced Topics » Additional Software (PETs, n' stuff) » System
Jump to:  

Rules_post_cannot
Rules_reply_cannot
Rules_edit_cannot
Rules_delete_cannot
Rules_vote_cannot
You cannot attach files in this forum
You can download files in this forum


Powered by phpBB © 2001, 2005 phpBB Group
[ Time: 0.0986s ][ Queries: 12 (0.0066s) ][ GZIP on ]