Puppy Linux Discussion Forum

[technosaurus]

Many have noted the really annoying bug in jwm prior to flash 10 jwm prevented fullscreen

I think I have finally discovered why by playing with the group settings to try and force it.

the flash video gets its name from the parent (checked using sleep5 && xwininfo <-- needed sleep so I could click the fullscreen button)

adding these should force fullscreen
<Group>
<Class>seamonkey-bin</Class>
<Name>seamonkey-bin</Name>
<Option>pignore</Option>
<Option>hmax</Option>
<Option>vmax</Option>
<Option>maximized</Option>
</Group>

the maximized tag works as normal for seamonkey-bin as long as hmax or vmax is not in place, however adding them PREVENTS instead of forcing maximization

it appears that flash10 just uses maximize while flash9 uses HMAX and VMAX

flash9 is still being updated and is 2MB smaller with less dependencies so it would be nice to get this fixed ... who knows what other issues it will fix along the way - I think there was a related gxine bug too

Hopefully someone can confirm - I could be completely off base because I have zero C skills... anyone???

EDIT --- further info
from joewing.net documentation
hmax Make windows in this group maximize horizontally by default.
vmax Make windows in this group maximize vertically by default.

hmax expected - window opens maximized horizontally
hmax actual - window opens as normal when maximize is press it ONLY maximizes horizontally

hmax & vmax expected - window opens maximized horizontally and vertically
hmax & vmax actual - window opens as normal when maximize is press it does not maximize at all

it seems like jwm is setting the window state as maximized (V or H) instead of performing the action

for instance in hint.h there is

ATOM_NET_WM_ACTION_MAXIMIZE_HORZ,
ATOM_NET_WM_ACTION_MAXIMIZE_VERT,

and

ATOM_NET_WM_STATE_MAXIMIZED_VERT,
ATOM_NET_WM_STATE_MAXIMIZED_HORZ,

seems like this is a likely culprit, but I don't think I can debug any further

[AF Branden]

I would LOVE to see this fixed, unfortunately I have no programming skills. Also, this isn't just limited prior to flash 10; I have flash 10.1 r53 and I still have this problem. Also using seamonkey 1.1.15.


I'll probably try HairyWill's patch and see how it works
http://www.murga-linux.com/puppy/viewtopic.php?p=272409#272409

[technosaurus]

patriot's patch fixes this and is now upstream as of jwm-svn-500