(old)Puppy Linux Discussion Forum

broomdodger wrote:

zigbert wrote:broomdodger
Thank you for the report.
I will check it out.... It will probably take some time since the next version seems to be 2.2 - with new goodies

When will that be available? Will you announce it here?

It will still take a while, and it will be announced here


Sigmund

broomdodger wrote:wary 5.2
pmusic 2.1.8

Watching 'top' memory size (vsz and %mem) gtkdialog4 used by pmusic, the memory usage keeps increasing and can get quite high, 60% !

Is this a memory leak in gtkdialog4 or something pmusic is doing?

from top:
gtkdialog4 -f /root/.pmusic/tmp/xml_Pmusic -G +0+0

Hmm, not good. I need to know the actual process that is not handled correct. Please execute the following command in a terminal and post the result here
Thank you
Sigmund

darkcity wrote:Shouldn't cd ripping be added to the feature list on the first post?

It is already there

Playback (and ripping) of audio-CD

Sigmund

Here is a snappy for the interested one

Pmusic 2.2 will offer a new WebMusic module with access to all music at jamendo.com. It is fully integrated with Pmusics infrastructure...

INPUT: 2000000+ tracks available directly from server or even better via index-file (download or build).
TREAT: Search, browse, full track-info support with lyrics and album art, ...
OUTPUT: Export music to local files to your preferred format.



Managing a increasing collection of music, we need better search-tools.... In this work, I have also added support of ordinary file-search via pfilesearch. This is great for those who use Pmusic as a basic player of local files, and don't care about index' and streams. By default the user should not need to bother of advanced settings, but for the power-user, there should be possibilities...

zigbert wrote:

broomdodger wrote:wary 5.2
pmusic 2.1.8

Watching 'top' memory size (vsz and %mem) gtkdialog4 used by pmusic, the memory usage keeps increasing and can get quite high, 60% !

Is this a memory leak in gtkdialog4 or something pmusic is doing?

from top:
gtkdialog4 -f /root/.pmusic/tmp/xml_Pmusic -G +0+0

Hmm, not good. I need to know the actual process that is not handled correct. Please execute the following command in a terminal and post the result here

Code: Select all

ps | grep pmusic

211224 ps | grep pmusic
6606 root 0:00 /bin/bash /usr/local/bin/pmusic
6607 root 0:00 /bin/sh /usr/local/pmusic/pmusic
6651 root 0:00 /bin/sh /usr/local/pmusic/func -tray_app
6658 root 0:00 /usr/local/pmusic/pmusic_tray
6705 root 0:10 gtkdialog4 -f /root/.pmusic/tmp/xml_Pmusic -G +0+0
6717 root 0:00 sh -c while [ ! -f $WORKDIR/end_while_add ]; do cat /root/.pmusic/tmp/load_id3; echo " "; sleep 2; done
18759 root 0:00 /bin/bash /usr/local/pmusic/func_player -playing -refresh
18819 root 0:00 /bin/sh /root/.pmusic/tmp/exec
19338 root 0:00 /bin/sh /usr/local/pmusic/func_progressbar
19341 root 0:00 grep pmusic
19342 root 0:00 /bin/sh /usr/local/pmusic/func_progressbar

These two from top about 20 seconds apart:
PID PPID USER STAT VSZ %MEM CPU %CPU COMMAND
6705 6607 root S 47156 9% 0 1% gtkdialog4 -f /root/.pmusic/tmp/xml_Pmusic -G +0+0

about 20 seconds later
6705 6607 root S 47620 9% 0 1% gtkdialog4 -f /root/.pmusic/tmp/xml_Pmusic -G +0+0

broomdodger
It looks like it works ok, but you seem to have an older (low-powered) system. I checked my crappy laptop from 2007, and gtkdialog4 -f /root/.pmusic/tmp/xml_Pmusic -G +0+0 shows 2% while yours said 9%.

The best proposal for weaker hardware is to set up the playlist in Pmusic. - When done, click on the tray-icon and Pmusic will play in background until you click on the tray-icon again. The Pmusic-backend is not too cpu-hungry. It is the frontend using gtkdialog that steals your power.


Sigmund

zigbert wrote:broomdodger
It looks like it works ok, but you seem to have an older (low-powered) system. I checked my crappy laptop from 2007, and gtkdialog4 -f /root/.pmusic/tmp/xml_Pmusic -G +0+0 shows 2% while yours said 9%.

Sigmund
ThinkPad 1.2GHz 512MB ram
The problem I see in NOT cpu usage which is at 1% or less, but mem leak.
pmusic starts off small keeps grabbing more mem, I saw it up to 60%.
SeaMonkey never gets that high!
-Bill

broomdodger
Sorry for my misunderstanding....

But since you refer to the frontend (gtkdialog4 -f /root/.pmusic/tmp/xml_Pmusic -G +0+0), it would be good to know if it helps to click the tray-icon. The frontend pid should then be killed, and hopefully, memory will be free.

Also, there is a troublesome option that is activated by default. You will for sure benefit of turning it off. Pmusic is working hard during the loading of meta-tags.




Sigmund

broomdodger wrote:These two from top about 20 seconds apart:
PID PPID USER STAT VSZ %MEM CPU %CPU COMMAND
6705 6607 root S 47156 9% 0 1% gtkdialog4 -f /root/.pmusic/tmp/xml_Pmusic -G +0+0

about 20 seconds later
6705 6607 root S 47620 9% 0 1% gtkdialog4 -f /root/.pmusic/tmp/xml_Pmusic -G +0+0

There are a couple of things worth checking here:
1) /root/.pmusic/tmp/xml_Pmusic and the memory footprint when Pmusic is started:
- maybe the "XML" (sic) file contains a lot of info (complicated UI and data) and ends up using a lot of memory
- maybe gtkdialog uses a lot of memory with some things (or has a memory leak).

2) Note how your "ps" output showed multiple instances of func_progressbar. It doesn't make sense that there are multiple progressbar instances at the same time...
They might be zombies (ps x | grep Z), but it might be that the progressbar function hangs (when the progressbar ends), in which case the func_progressbar (sub-)processes don't exit -- and don't release their memory (hence a memory leak). (You can try "ps xf" to see the hierarchy of the Pmusic processes and I suspect that all func_progressbar instances will be at the same level.)

Version 2.2.0
See main post

Changelog
- Full integration of Jamendo.com via the webmusic module.
. . . INPUT: 238000 tracks available directly from server or even better via index-file (download or build).
. . . TREAT: Search, browse, full track-info support with lyrics and album art, ...
. . . OUTPUT: Export music to local files to your preferred format.
- Improved search.
. . . Search for files is supported via pfilesearch 1.27.
. . . Define search-filters from search-field or preferences.
- Radio
. . . One-click install of radio index.
. . . Seperated radio into tags/country.
. . . updated index.
- Bookmarks-dialog should now be less awkward.
. . . One click (OK-button or press enter) to save given bookmark.
. . . Gui cleanup.
. . . Open with no default bookmark when starts from File>Bookmark manager.
- 'Rating' has replaced 'Most played'.
. . . increase value when song is played (finished).
. . . decrease value when skip.
. . . Show points in Music-sources.
. . . Edit Rating points in track-info window
- Optimized the add function for faster adding to playlist.
- Faster lyrics detection. Lyricwiki.org performs best and is default.
- 'Index' has been renamed to 'My Music'
- Faster detection of BROWSER at startup.
- Preferences button in CD preset --> show only playback tab. (thanks to playdayz)
- Rewritten Mananger preset.
- Updated Classic and Wings preset.
- Option: Load meta-tags for the first X number of tracks in sourcelist (default is 50).
- Removed buttons to clear history of recent/rating index. It is still editable.
- Bugfix: 'Add all' / 'Add random' still uses 59:59 for streams.
- Bugfix: Remove headings and empty lines in sourcelist when sort.
- Bugfix: Don't use resources to try reading meta info of collections and streams after search.
- Bugfix: Remove temporary files when Pmusic quits.
- Bugfix: Pmusic -D doesn't detect gtkdialog-0.8 correct. (thanks to broomdodger)
- Bugfix: Use m3u length for http-streams if defined.
- Bugfix: Show no result if search for empty string (blank searchfield).
- Bugfix: Save m3u (without paths) containg URLs.
- Bugfix: button to select default browser dir in preferences.
- Bugfix: Multiple playtlists doesn't save correct (thanks to broomdodger)
- Bugfix: Pref button in podcast manager.
- Bugfix: mass-tagging: setting Genre doesn't work.
- NLS: Added: LOC_ADVANCED, APPLY, BROWSE, COUNTRY, INSTALL, SEARCH, 228, 495, 635, 636, 637, 811, 812, 845
- NLS: Changed: LOC104, 223, 226, 237, 238, 301, 318, 406, 407, 490, 491, 493, 630, 631
- NLS: Removed: LOC269, 276, 463, 809, 810

Dougal

- maybe the "XML" (sic) file contains a lot of info (complicated UI and data) and ends up using a lot of memory
- maybe gtkdialog uses a lot of memory with some things (or has a memory leak).

I am not the one to tell the reason why gtkdialog uses more resources than a compiled code, but it obviously does. But I find it strange that Pmusic should use 60% of 512Mb RAM. - That is a lot...

2) Note how your "ps" output showed multiple instances of func_progressbar. It doesn't make sense that there are multiple progressbar instances at the same time...

Well, that could make perfectly sense. The func_progressbar is not a loop running in the background. It is a function called from the gui each 0.2 sec, and depending on its output, it might not be finished before next call. Most of these calls quits immediately, but some will occupy the system with larger requests. When a new track is started, func_progressbar will update the values of NOW_PLAYING. This require 'ffmpeg -i', and for streams, that could in particular take some time.


Thank you for your input and concern
Sigmund

Racy 5.1.110
Pmusic-2.2.0

Playlists are remembered, thank you for the fix.
Music plays, seems to work well.

-Bill

Racy 5.1.110
Pmusic-2.2.0

When starting pmusic from the cli, it shows seamonkey which is not running. This seems odd!

" -------1---------2---------3---------4---------5---------6----
094244 pmusic
/usr/bin/seamonkey




ADDMODE=""
ARTWORK=""
BALANCE="100"
BUTTON_PLAY=""
PLAYLIST=""
PLAYLIST_ALL="'001 /mnt/home/music/Sandy Bull/RE-INVENTIONS/01 Blend.mp3' '002 /mnt/home/music/Sandy Bull/RE-INVENTIONS/07 Triple Ballade.mp3' '003 /mnt/home/music/Sandy Bull/RE-INVENTIONS/Carnival Jump.mp3'"
PLAYMODE=""
PROGRESS="3"
SEARCH="/mnt/home/music"
SEARCHPATH="/mnt [OR] /root"
SEARCH_FILES="false"
SEARCH_MYMUSIC="true"
SEARCH_RADIO="false"
SEARCH_WEBMUSIC="false"
SOURCE=""
STATUSBAR=" (32:06) List 2 (0:12/8:49) Sandy Bull - Carnival Jump"
VOLUME="100"
EXIT="quit"
/usr/local/pmusic/func: line 7: 17007 Terminated $APPDIR/pmusic_tray
" -------1---------2---------3---------4---------5---------6----

-Bill

broomdodger Seamonkey is determined as default web-browser. - that's all.
But still, there is no need to give the output. I will fix....


Sigmund

Version 2.2 introduce a nifty (I learned that word from Barry ) button. Pmusic has always been made for large music collection, but version 2.2 is made for huge collections. Since jamendo.com gives access to 250000+ tracks there was a need of an improved search engine. The new button gives quick access to search filters.

Dear God I am struggling with Pmusic. I seem unable to index my music. Each time I return to the browser window after indexing it reports 'index missing' (Racy) Whatever am I doing wrong? Surely it should not be this difficult?

DaveS wrote:Dear God I am struggling with Pmusic. I seem unable to index my music. Each time I return to the browser window after indexing it reports 'index missing' (Racy) Whatever am I doing wrong? Surely it should not be this difficult?

Huh... seems Pmusic cant index via a symlink, path has to be absolute. Who would have known.......
Once given an absolute path to my music directory at /mnt/ home/Music/, indexing works, specifiying a path which includes a symlink (/root/Music) where Music is a symlink fails.

219 seems to be able to build indexes, but then says they dont exist in the browser window.

DaveS wrote:219 seems to be able to build indexes, but then says they dont exist in the browser window.

Exactly the same with 220.

183 indexes fine but cant display genre