Puppy Linux Discussion Forum

[pemasu]

Pmusic-2.3.0 and fresh compile of ffmpeg-0.9.1 gives error with dependency checking.

[zigbert]

Pemasu
Yes I have seen this earlier; building from git produces another version string. I am on holiday at the moment, and it is out of reach to fix. But I will try to remember this until I get home - That's a challenge


Thank you for mention it
Sigmund

[linuxcbon]

Tested on wary 5.2.2 : installed pmusic 2.3.0

- why does it download by default the album photo from the internet ?
- In track info, doesnt display french letters like é properly.
- In track info, stream data are not shown :
Audio format: Audio
Samplerate (hz): Audio
Channels: Audio
Bitrate (bits/sec): Audio

[linuxcbon]

wary 5.2.2 pmusic 2.3.0

- # pmusic &
[1] 25147
# /usr/local/pmusic/gui_menu: line 104: /root/.pmusic/tmp/radiohits_presets: No such file or directory

- why is there a hoovers - ride with me by default ?
- when I double click hoovers to play :
aplay: playback:2297: read error

- dependency check :
ffmpeg >= 0.8 /usr/local/pmusic/pmusic: line 195: [: git: integer expression expected
[MISSING]
streamripper (extended radio-rip/play) [MISSING]
pFilesearch (File-search engine) >= 1.28 [MISSING]
pEqualizer (10 band equalizer) [MISSING]

[zigbert]

linuxcbon
First of all: thank you for testing!!!!

[zigbert]

[linuxcbon]

Track info : track :
I added utf-8 to chooselocale and restarted X, it still shows the same.
For instance it shows \Uffffffff instead of é.

ffmpeg -i song.mp3
Displays : title, genre, album, album_artist, track, artist, TLEN.
And then : Duration: 00:03:06.41, start: 0.000000, bitrate: 128 kb/s
Stream #0:0: Audio: mp3, 44100 Hz, stereo, s16, 128 kb/s

Hoovers :
Connecting... and nothing.

[zigbert]

linuxcbon
Thank you for your response, but it does not tell if ffmpeg spells the french title correct. It would be good to know if ffmpeg is the source of the issue or if it is gtk/gtkdialog.

Regarding stream data, I will need to check this out when I am home from holiday (yet another week )

Statusbar info shows correct. I see, there is no specific info when connection fails. I am not sure that this can be solved with existing code-structure. Will check as well....


Thanks
Sigmund

[Dougal]

[zigbert]

[zigbert]

Version 2.4.0
See main post

Changelog
- Save/load lyrics and album art to local storage (optional).
- Trackinfo
. . . Gui can auto-refresh when playing new track.
. . . Dynamic trackinfo integrated in Wings frontend.
. . . Static trackinfo (for chosen track only) via right-click menu in playlist.
. . . Manager frontend (default) will refresh if showing external trackinfo-window of playing track.
. . . Use icons to show id3tag-status instead of background color. More flexible and refreshable in xml-code.
. . . Message when lyrics/musicbrainz fails because of missing meta-info.
. . . Refresh button to update Lyrics, Albumart, ... based on edited meta-info.
. . . Albumart grabber is no searching amazon.com by default.
. . . . . . freecover.com has been down for too long.
. . . . . . Offers larger images.
. . . . . . Albumart.org is still the second choice if amazon.com fails.
- Rewritten code to update gui on external calls - not user interactions.
. . . This was required to show dynamic trackinfo.
. . . Faster browsing using internal browser.
. . . New parameter -U to force alternative update inteval of progress slider +++.
. . . Slightly reduced cpu-usage.
. . . Widget <progressbar> is gone.
- Cleanup in running PIDs.
- Much faster startup (not at first run when initializing new frontend).
. . . Do not build xml-code if it the same as last time.
. . . Introduced optional .pre files for each frontend to overide default settings
- Improve the albumart grabber from albumart.org to download a bigger image
- Settings in rc-file does not need to be in preferences window only.
. . . Split rc file in different sections.
. . . Lyrics and albumart storage options stores directly from trackinfo window.
- Bold text in statusbar. (By updating the default theme).
- Classic frontend is removed.
- Reorganized the bookmark manager window.
- Hot-key (ctrl+J) for 'jump to time'. Handy in LowPowered mode wih no slider.
- Added a blank.png for misc use.
. . . Use blank.png in $APPDIR as gtk-missing-icon. Define in gtkrc.
- Added 'diff' to dependency check.
- New parameter -T to overwrite defined theme.
- First run info.
. . . I want music.
. . . My system is low powered.
- Use pmusic icon as window-icon. (thanks to Geoffrey)
- Bugfix: Some terminal output.
- Bugfix: Preferences denied showing up if no audio-editor or browser app was set.
- Bugfix: Switch back to theme-albumart if connection to web fails.
- Bugfix: Play-icon in playlist doesn't show when first track autostarts.
- Bugfix: Get rid of empty lines in the RadioHits menu / Overview.
- Bugfix: Bookmark sourcelist gives blank bookmark-fields by default.
- Bugfix: Pmusic failed to startup if a playlist name was cleared.
- Bugfix: Hoovers at first run only if connected to internet. (thanks to linuxcbon)
- Bugfix: Icon in ok-box heading <window>.
- Bugfix: Eject CD-audio disc while playing didn't stop aplay.
- Bugfix: Pmusic froze when loading CD, and cdda2wav -cdd1=1 troubles with connecting to internet db.
- Bugfix: Dependency check fails for ffmpeg when compiled from git. (thanks to pemasu)
- Bugfix: Unstable gtk troubled in Manager to select sliders because of hidden <timer> height=1.
- Bugfix: Change frontend from menu at first run.
- NLS: Added: LOC_LOADING, SAVE, 208, 672, 673, 674, 900, 901, 902, 903
- NLS: Changed: LOC648, 649, 650, 659, 680, 681, 682, 691, 692, 761, 810, 843
- NLS: Removed: LOC131, 653, 665

[zigbert]

I will here explain the new event-handling in Pmusic 2.4.0. It is a smarter way to update gui on non-user-actions. User-actions is mouse-clicks and key-entries, and is the common way to interact between user and gui. An example of updating the gui on a non-user-action in Pmusic is the loading of id3-tags for files shown in the file-browser....

When clicking on a directory, the browser field refreshes and shows the content of the new directory. Now, Pmusic continues with a background process to read the id3 information of the files. When finished, the browser field should be updated by the new info. - Without the user to click anywhere.

The solution is to either use a <progressbar> which runs its <action> when reaches 100% or a <timer> which acts at a given interval. Older Pmusic releases used the <progressbar> solution while recent code uses a <timer>. Both solutions has the downside that they uses an amount of cpu power. In a complex gui with several non-user actions this could end up with several cpu-hungry <timers> updating their unique widget(s) of the gui.

Pmusic has used 2 <timers> running constantly to update their defined gui-part. You might think that 1 <timer> would be enough, - it could refresh all wanted widgets - it wouldn't harm if the refreshing didn't change anything. BUT, refreshing has an effect on the focus handling. It simply resets the focus, which means that:
- scrolling in <table> is moved to top.
- what you are about to write in an <entry> is cleared.
- Your selected item in the <tree> is not selected anymore
- ...

The idea of Pmusic 2.4.0 was to update all kinds of trackinfo (meta-tags, lyrics, albumart, discography, ...) when a new track starts playing. This would not be possible with the underlaying event-handling in Pmusic because it would either suck you cpu-power (with several <timers>), or a global refreshing would make it impossible to be a user (because of focus issues). Also, there is a fact that too many refreshing <action> on a <timer> will increase cpu-usage as well.

So the solution has been to add ONE <timer>, which refreshes a small set of <checkboxes> that (if true) refreshes a single or group of widgets.

<checkboxes> can be set true or false by their <input file>, so we can simply 'echo true' to its <input file>. The <timer> runs its <actions> each second, and the <checkbox> will be refreshed by its <input file>. The code could look like this:

[vovchik]

Dear Zigbert,

Again, great work. Here is a little icon I prefer for radio (/usr/local/pmusic/themes/Default/album_art_radio.png), but it's all a matter of personal preference.

Thanks.

With kind regards,
vovchik

[pemasu]

Pmusic-2.4.0 under testbench. Looks great and sounds better.
Small fixes I made. Nad3 theme misses in gtkrc:
style "icon-style"
{
stock["gtk-add"] = {{ "stock_add.png", *, *, *}}
stock["gtk-undo"] = {{ "stock_undo.png", *, *, *}}
stock["gtk-redo"] = {{ "stock_redo.png", *, *, *}}
stock["gtk-properties"] = {{ "stock_properties.png", *, *, *}}
stock["gtk-stop"] = {{ "stock_stop.png", *, *, *}}
stock["gtk-missing-image"] = {{ "blank.png", *, *, *}}
above bold line is missing.

Also blank.png symlink is missing from nad3 folder.
My hacked Nad3 theme included.

[zigbert]