The time now is Sun 19 May 2013, 11:11
All times are UTC - 4 |
| Author |
Message |
clarf

Joined: 13 Jun 2007 Posts: 606 Location: The old Lone Wolf
|
Posted: Wed 01 Sep 2010, 18:09 Post subject:
code bug in pnethood-0.6.5 and quick solution |
|
Hi HairyWill,
I just found a code bug in pnethood-0.6.5. The offending code at line 19 is:
| Code: | | [ -e "$/tmp/pnethood/log" -a $(du /tmp/pnethood/log | sed 's/\([0-9]*\).*/\1/') -gt 100 ] && : > ${TMP}log #clear log at 100K |
Actually the clear operation does not work, because the test command "-e" is evaluating a invalid string (in this case the $ sign is the culpable). This peace of code also shows a shell error (too many arguments and du cannot access log file) if the /tmp/pnethood/log path does not exits, indicating that it fails to evaluate both tests.
A functional code without errors is:
| Code: | if [ -e "/tmp/pnethood/log" ] && [ $(du /tmp/pnethood/log | sed 's/\([0-9]*\).*/\1/') -gt 100 ]; then
: > ${TMP}log #clear log at 100K
fi |
With this new code, the log file is effectively cleaned when it grows beyond the 100kB. The first test command prevents the du command to execute if the file does not exist.
Others implementations for this solution can be applied, but this it the first I implemented (and it actually works as desired)
HairyWill, I Hope to see a new pnethood version soon, there are many users that stills like it.
Greetings,
clarf
|
|
Back to top
|
|
 |
Arthur
Joined: 10 Nov 2008 Posts: 15 Location: Earth
|
Posted: Wed 01 Sep 2010, 19:25 Post subject:
seconded Subject description: pnethood |
|
| clarf wrote: |
I must add that I like Pnethood, it works, it´s fast and have a good look and feel. Is sad to know that you won´t update Pnethood any more, |
Absolutely - it's one of the programs on puppy which gets the most use. Along with grsynch it is how I keep my files in order. Only improvement I can think of is making it more forgiving of faliure to disconnect from the samba share before the share disappears - human error is a terrible thing and I've trashed my puppy this way a few times.
|
|
Back to top
|
|
 |
clarf

Joined: 13 Jun 2007 Posts: 606 Location: The old Lone Wolf
|
Posted: Thu 09 Sep 2010, 15:00 Post subject:
|
|
I recently found some small bugs in Pnethood and I want to share my fixes, at same time I want to join some Pnethood patches that I found in the Puppy forum and make a new version to add those changes.
I know there are many Pnethood variants that fixes some things. That is a problem because confuse users about which is the latest version, makes the report of new bugs a problem (they could be already fixed in some private version) and without an unificated version its difficult to further support Pnethood.
HairyWill already mentioned he will not support Pnethood anymore. So, I sent a PM to HairyWill three months ago, basically I requested and approval to launch an official new version by myself, but he seems to be very busy and out of any Puppy Linux development in this moment.
I´ll wait a little more for an answer. Meanwhile I´ll continue to test this beta new Pnethood "0.6.6 version" of mine.
Any comment is welcome
Greetings,
clarf
|
|
Back to top
|
|
 |
clarf

Joined: 13 Jun 2007 Posts: 606 Location: The old Lone Wolf
|
Posted: Thu 09 Sep 2010, 15:00 Post subject:
|
|
duplicated
|
|
Back to top
|
|
 |
disciple
Joined: 20 May 2006 Posts: 6179 Location: Auckland, New Zealand
|
Posted: Thu 09 Sep 2010, 16:21 Post subject:
|
|
If you want to maintain a single pnethood package, be aware that one of the fixes that makes it work with more recent puppies also stops it from working on slightly older puppies.
_________________ DEATH TO SPREADSHEETS
- - -
Classic Puppy quotes
- - -
Beware the demented serfers!
|
|
Back to top
|
|
 |
clarf

Joined: 13 Jun 2007 Posts: 606 Location: The old Lone Wolf
|
Posted: Thu 09 Sep 2010, 21:44 Post subject:
|
|
| disciple wrote: | | If you want to maintain a single pnethood package, be aware that one of the fixes that makes it work with more recent puppies also stops it from working on slightly older puppies. |
Thanks for the advice disciple.
I took the official 0.6.5 version as the regular base and then applied one for one all the fixes I have, these fixes are very specific and I don´t think anything will be broken for any puppy version.
I haven´t seen any fix to make it work with more recent puppies yet. But I´ll do a cross version test.
salutes,
clarf
|
|
Back to top
|
|
 |
disciple
Joined: 20 May 2006 Posts: 6179 Location: Auckland, New Zealand
|
Posted: Fri 10 Sep 2010, 05:54 Post subject:
|
|
Are you using any patches to the mount command?
_________________ DEATH TO SPREADSHEETS
- - -
Classic Puppy quotes
- - -
Beware the demented serfers!
|
|
Back to top
|
|
 |
clarf

Joined: 13 Jun 2007 Posts: 606 Location: The old Lone Wolf
|
Posted: Fri 10 Sep 2010, 11:50 Post subject:
|
|
Well, I´m using a modified code for the mount command.
Basically, I added to mount commands:
1. The iocharset=utf8 parameter when using cifs.
2. The workgroup=$DOMAINID parameter if user enabled Domain action (with and without cifs)
clarf
|
|
Back to top
|
|
 |
Mark_C
Joined: 28 Aug 2010 Posts: 28
|
Posted: Wed 22 Sep 2010, 08:12 Post subject:
|
|
clarf
Would you know if Pnethood has some sort of limitation on the number of computers it can see on the network?
We have 19 computers at work and it will only see 17 of them.
The two it doesn't see are the last two I set up for new employees, I originally thought maybe I had done something wrong setting them up but they see the whole network and others can see them.
I then booted puppy 3 and Linneighborhood sees all 19 so I figure it is something in pnethood.
Mark
|
|
Back to top
|
|
 |
disciple
Joined: 20 May 2006 Posts: 6179 Location: Auckland, New Zealand
|
Posted: Sat 25 Sep 2010, 05:36 Post subject:
|
|
Can lameSMBxplorer see them?
_________________ DEATH TO SPREADSHEETS
- - -
Classic Puppy quotes
- - -
Beware the demented serfers!
|
|
Back to top
|
|
 |
Mark_C
Joined: 28 Aug 2010 Posts: 28
|
Posted: Sat 25 Sep 2010, 13:38 Post subject:
|
|
I am pretty sure I tried LameSMBxplorer but I don't remember the results.
It either saw less or the same, I will have to try it again Monday and see what it does.
The strange thing is that some older Puppy versions with Pnethood only see 10 computers, even though they say they are the same version of Pnethood as in Lucid Puppy so there must be some difference.
I tried installing Linneighborhood in Lucid 5.1.1 and it works, except you cant mount the shares, it seems at some point Mtab was changed to a symbolic link and that messes up the mounting of shares. I tried changing Mtab to make it not a link and after that you can mount the shares but the system changes it back to a symbolic link on reboot.
|
|
Back to top
|
|
 |
Sit Heel Speak

Joined: 30 Mar 2006 Posts: 2595 Location: downwind
|
Posted: Mon 27 Sep 2010, 18:57 Post subject:
|
|
| Mark_C wrote: | | Would you know if Pnethood has some sort of limitation on the number of computers it can see on the network? |
Two years ago, I saw a network of 12 Windows XP machines on which PNethood would see only 11 unless the scan time was raised.
|
|
Back to top
|
|
 |
Mark_C
Joined: 28 Aug 2010 Posts: 28
|
Posted: Tue 28 Sep 2010, 12:32 Post subject:
|
|
I set it to 30 seconds, which is the max on the menu, but it didn't make a difference, thank you for the tip though.
| Sit Heel Speak wrote: | | Mark_C wrote: | | Would you know if Pnethood has some sort of limitation on the number of computers it can see on the network? |
Two years ago, I saw a network of 12 Windows XP machines on which PNethood would see only 11 unless the scan time was raised. |
|
|
Back to top
|
|
 |
Mark_C
Joined: 28 Aug 2010 Posts: 28
|
Posted: Tue 28 Sep 2010, 13:04 Post subject:
|
|
Ok here are some things I tried today.
LameSMBxplorer doesn't seem to work in Lucid Puppy 5.1.1 it just scans and scans and locks up the network, I have to reboot the computer to free up the network(strange).
So I tried it in Fluppy and it sees 14 computers.
|
|
Back to top
|
|
 |
rcrsn51

Joined: 05 Sep 2006 Posts: 7744 Location: Stratford, Ontario
|
Posted: Tue 28 Sep 2010, 13:17 Post subject:
|
|
Just out of curiosity, what happens if you run nbtscan from the command line. Can it see all the machines?
|
|
Back to top
|
|
 |
|
|
|
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum You cannot attach files in this forum You can download files in this forum
|
Powered by phpBB © 2001, 2005 phpBB Group
|