Author |
Message |
BarryK
Puppy Master

Joined: 09 May 2005 Posts: 8526 Location: Perth, Western Australia
|
Posted: Sat 16 Apr 2016, 10:52 Post subject:
InkscapeLite, bug fix, another needs fixing Subject description: Our old InkscapeLite still has life |
|
InkscapeLite has been in most pups for years, and I still have it in Quirky.
Why? It is so small, the last version of Inkscape written in C, before they rewrote it in C++.
Very handy for knocking up vector diagrams, or constructing composite bitmap images (it will import png images). Can also export to png.
Handy little app, but has some issues. One of those was the cursor in the horizontal ruler not erasing as it moved. Finally it is fixed, thanks to SFR:
http://murga-linux.com/puppy/viewtopic.php?p=897736#897736
But there is another bug. The vertical ruler is hidden. I noticed this recently, don't know when it appeared. Obviously some change in GTK2 has caused it.
This snapshot shows the bug: see attached.
SFR was working with 0.36.2, which seems to be older source. I have 0.36.3, and his patch did not work, so I had to create a new one.
If anyone with a smattering of C coding ability would like to have a go at fixing this, please do!
Here is the source:
http://distro.ibiblio.org/quirky/quirky6/sources/t2/april/inkscapelite-0.36.3.tar.bz2
I have the patches and configure info from T2. File inkscapelite.conf is easy to read.
On a 64-bit build, this is the full configure line:
Code: | # ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --build=x86_64-pc-linux-gnu --with-popt --with-xft --without-gnome-print --disable-mmx |
SFR commented that the text tool does not work with the 64-bit compile. Yes it does, with my source.
His comment about not being able to open many SVG files, is correct. SVG files that it creates are OK, as are others using fairly generic SVG code. Perhaps that could be another project.
This is a great little app, it will be great if we can keep it alive.
Description |
Patches and config info from T2
|

Download |
Filename |
inkscapelite.tar.gz |
Filesize |
3.17 KB |
Downloaded |
195 Time(s) |
Description |
|
Filesize |
10.28 KB |
Viewed |
1036 Time(s) |

|
_________________ http://bkhome.org/news/
|
Back to top
|
|
 |
amigo
Joined: 02 Apr 2007 Posts: 2641
|
Posted: Sat 16 Apr 2016, 14:37 Post subject:
|
|
Interesting. Thanks for posting. I have a version of the original 0.36 sources which I massaged a bit. I find the old version-controlled sources for the few days when the 'big switch' was made to C++. There was some useful stuff that went in just after the 0.36 release, but before the re-write started.
|
Back to top
|
|
 |
BarryK
Puppy Master

Joined: 09 May 2005 Posts: 8526 Location: Perth, Western Australia
|
Posted: Sat 16 Apr 2016, 21:15 Post subject:
|
|
I can't recall the exact history of how my 0.36.3 source came about.
I think it might have some of my own modifications in it.
amigo,
Yes, it would be great if you can take a look at it.
SFR sent me a PM, he found the patch on the Internet, I think he actually got the fix for the horizontal ruler from the full inkscape project.
I know that they had that bug for a very long time.
_________________ http://bkhome.org/news/
|
Back to top
|
|
 |
BarryK
Puppy Master

Joined: 09 May 2005 Posts: 8526 Location: Perth, Western Australia
|
Posted: Sat 16 Apr 2016, 21:44 Post subject:
|
|
Ah ha! The hidden vertical ruler was fixed in Inkscape 0.47:
https://bugs.launchpad.net/inkscape/+bug/354274
...so where is the patch?
_________________ http://bkhome.org/news/
|
Back to top
|
|
 |
SFR

Joined: 26 Oct 2011 Posts: 1655
|
Posted: Sun 17 Apr 2016, 03:48 Post subject:
|
|
BarryK wrote: | I think he actually got the fix for the horizontal ruler from the full inkscape project. |
No. IIRC I tried that at first, but the code in ruler.cpp is way too different.
But I found it - it was GIMP (Toolkit).
http://www.cs.cmu.edu/afs/cs.cmu.edu/project/learn-43/lib/photoz/.g/scottd/gtk/gtk+-0.99.3/gtk/gtkruler.c
(scroll down to the very bottom)
Greetings!
_________________ [O]bdurate [R]ules [D]estroy [E]nthusiastic [R]ebels => [C]reative [H]umans [A]lways [O]pen [S]ource
Omnia mea mecum porto.
|
Back to top
|
|
 |
BarryK
Puppy Master

Joined: 09 May 2005 Posts: 8526 Location: Perth, Western Australia
|
Posted: Sun 17 Apr 2016, 04:19 Post subject:
|
|
Got it!
I hunted around on the Inkscape Bazaar repository, couldn't find the fix, so I thought, why not ask one of the developers?
So I did. I asked Diederik, and he responded straight away, with this URL:
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/7543
I managed to adapt the changes to src/widgets/ruler.c, and the patch is enclosed. And a snapshot for proof.
The numbers on the vertical ruler look a bit off, but good enough for now.
I have added this patch to T2.
Description |
Fixes squashed vertical ruler
|

Download |
Filename |
04-inkscapelite-fix-vruler.patch.gz |
Filesize |
496 Bytes |
Downloaded |
182 Time(s) |
Description |
|
Filesize |
9.86 KB |
Viewed |
900 Time(s) |

|
_________________ http://bkhome.org/news/
|
Back to top
|
|
 |
SFR

Joined: 26 Oct 2011 Posts: 1655
|
Posted: Sun 17 Apr 2016, 09:56 Post subject:
|
|
Thanks for the patch, works fine.
Btw, an observation regarding the 'Text' tool on FD - selecting 'Text and Font' menu option also causes a segfault, but on a rare occasion it somehow works and after closing the dialog, Text tool also gets immune to segfault.
N.B.: building with CFLAGS='-g -O0' makes the 'Text and Font' option segfault-resistant every time.
___________
Here's (attached) unified patch for FD64-710, if anyone would like to build InkLite there.
Two issues, though:
1. Segfaults on attempt to use 'Text' tool.
2. Lacks numbers on both rules.
Greetings!
Description |
|

Download |
Filename |
inklite.patch.tar.gz |
Filesize |
1.34 KB |
Downloaded |
211 Time(s) |
_________________ [O]bdurate [R]ules [D]estroy [E]nthusiastic [R]ebels => [C]reative [H]umans [A]lways [O]pen [S]ource
Omnia mea mecum porto.
Last edited by SFR on Sun 17 Apr 2016, 10:49; edited 1 time in total
|
Back to top
|
|
 |
jamesbond
Joined: 26 Feb 2007 Posts: 3146 Location: The Blue Marble
|
Posted: Sun 17 Apr 2016, 10:20 Post subject:
|
|
@SFR - interested. Can you send me 710 pkgbuild tarball? (with all the other patches too?).
PS: the fact that you need -O0, perhaps you can instead use '-fno-strict-aliasing'.
Thank you.
_________________ Fatdog64, Slacko and Puppeee user. Puppy user since 2.13.
Contributed Fatdog64 packages thread.
|
Back to top
|
|
 |
SFR

Joined: 26 Oct 2011 Posts: 1655
|
Posted: Sun 17 Apr 2016, 10:43 Post subject:
|
|
@James:
I don't have a pkgbuild, the above is complete patch for this sources:
http://distro.ibiblio.org/quirky/quirky6/sources/t2/april/inkscapelite-0.36.3.tar.bz2
Hmm, I'm checking right now and it doesn't really seem to matter what CFLAGS are there - 'Text and Font' crashes in ~1 on 5 cases.
The mentioned observation comes from my previous struggles with InkLite, yet in FD64-700. I didn't fully check that on 710, until now.
EDIT: I just checked and for some reason the patch posted in my previous post fails, probably due to some issues with whitespaces.
I packed it into .tar.gz (attached in my previous post).
EDIT2: this package (for April64, yet without the patches for rulers) does not segfault in FD.
Greetings!
_________________ [O]bdurate [R]ules [D]estroy [E]nthusiastic [R]ebels => [C]reative [H]umans [A]lways [O]pen [S]ource
Omnia mea mecum porto.
|
Back to top
|
|
 |
jamesbond
Joined: 26 Feb 2007 Posts: 3146 Location: The Blue Marble
|
Posted: Mon 18 Apr 2016, 03:24 Post subject:
|
|
Thanks SFR. I'll to build it and see how it goes.
_________________ Fatdog64, Slacko and Puppeee user. Puppy user since 2.13.
Contributed Fatdog64 packages thread.
|
Back to top
|
|
 |
OscarTalks

Joined: 05 Feb 2012 Posts: 1728 Location: London, England
|
Posted: Mon 18 Apr 2016, 17:28 Post subject:
|
|
Did a test build in Dpup Wheezy.
Wasn't sure if I was supposed to apply the glib.h patch so tried without.
I applied the 2 ruler patches.
Then ran ./configure with options
Then ran the sed command from the .conf file to fix the "--export-dynamic" gcc error.
Then ran make and it completed and seems to run OK.
Thanks for this.
Description |
Ruler fixes applied in Dpup Wheezy |
Filesize |
64.52 KB |
Viewed |
692 Time(s) |

|
_________________ Oscar in England

|
Back to top
|
|
 |
BarryK
Puppy Master

Joined: 09 May 2005 Posts: 8526 Location: Perth, Western Australia
|
Posted: Mon 18 Apr 2016, 17:56 Post subject:
|
|
OscarTalks wrote: | Did a test build in Dpup Wheezy.
Wasn't sure if I was supposed to apply the glib.h patch so tried without.
I applied the 2 ruler patches.
Then ran ./configure with options
Then ran the sed command from the .conf file to fix the "--export-dynamic" gcc error.
Then ran make and it completed and seems to run OK.
Thanks for this. |
Yeah, removing "--export-dynamic", replacing it with "-lm" in the Makefile, is clumsy.
It would have been better if I had created a patch to fix it before running "configure ..."
Note, InkscapeLite on T2 was created by me, so I am the cause of the clumsiness.
_________________ http://bkhome.org/news/
|
Back to top
|
|
 |
SFR

Joined: 26 Oct 2011 Posts: 1655
|
Posted: Tue 19 Apr 2016, 06:28 Post subject:
|
|
jamesbond wrote: | Thanks SFR. I'll to build it and see how it goes. |
Thank you for your interest.
A tiny progress on the issue...
I built InkLite in PCLinuxOS and it does not segfault in Fatdog.
As for the missing numbers on rulers (in FD710) it can be fixed by reverting 'iso10646' to 'iso8859' in 'fixed' alias (/usr/share/fonts/X11/misc/fonts.alias):
Code: | fixed -misc-fixed-medium-r-semicondensed--13-120-75-75-c-60-iso8859-1 |
(xlock and xmessage still work fine despite that change, btw)
Of course it still would be best to make it build-able in Fatdog (with its default settings).
Can't attach the package here (509K), so I used TinyUpload:
http://s000.tinyupload.com/?file_id=07889487112804514113
MD5: 8298dda1006ee62402621dceece63722 inkscapelite-0.36.3-x86_64-1.txz
Greetings!
Description |
|
Filesize |
33.72 KB |
Viewed |
639 Time(s) |

|
_________________ [O]bdurate [R]ules [D]estroy [E]nthusiastic [R]ebels => [C]reative [H]umans [A]lways [O]pen [S]ource
Omnia mea mecum porto.
|
Back to top
|
|
 |
gjuhasz

Joined: 29 Sep 2008 Posts: 362
|
Posted: Wed 20 Apr 2016, 10:38 Post subject:
vector graphics reproduction bug |
|
The ruler is OK but the problems with svg file reproduction remained.
For example, Inklite fails to display some simple icons in /usr/share/pixmaps/puppy folder. See the screenshot attached for clock_interval.svg. Moreover, it displays a blank picture for others, e.g., for sound_eq.svg. The icons look well in ROX and also in in Viewnior.
It is strange that Inklite can correctly transform (e.g., rotate) them despite of the bad visualization.
Any idea? Thanks in advance.
Have fun!
Regards,
gjuhasz.
Description |
Inkscapelite 0.36 - svg reproduction in Tahr 6.0.5 |
Filesize |
53.89 KB |
Viewed |
541 Time(s) |

|
|
Back to top
|
|
 |
peebee

Joined: 21 Sep 2008 Posts: 3252 Location: Worcestershire, UK
|
Posted: Thu 21 Apr 2016, 13:14 Post subject:
|
|
Patched source now at:
http://distro.ibiblio.org/puppylinux/sources/i/inkscapelite-0.36.3_patched-glib-rulers.tar.xz
Change request for an amended slacko pet-build has been sent.
https://github.com/puppylinux-woof-CE/petbuilds/pulls
_________________
LxPup = Puppy + LXDE
|
Back to top
|
|
 |
|