Problem with Blinky

Message

BarryK · #41 Post by **BarryK** » Thu 09 Feb 2006, 23:01

Well, here it is anyway, in case anyone is interested.

I compiled it like this:

./configure --host=i486-pc-linux-gnu --disable-nls --enable-gnome=no
 make

lior2b · #42 Post by **lior2b** » Fri 10 Feb 2006, 17:08

I looked into gkdial, it is one piece of unmantained crap

I don't have dialup, hence I won't be able to really work on gkdial... isn't ther any mantained gtk1 dialer?

Anyway, I checked /etc/ppp/connect-errors, but the device name isn't listed... I won't be able to tell what device the speed is referring to... any ideas?

Last and most important thing... I compiled jwm 1.4 today, and I found two things:
1) I needed to change something about Blinky to make it integrate better with jwm (height issue), attaching the fixed one.
2) An issue we will probably have to address joe about: after loading jwm, the space allocated for Blinky remains static, and if I add/remove devices the space isn't changed in accordance. For example, if jwm is started while there is no active connection, no space will be allocated to Blinky, and when a connection will be found Blinky won't be able to show it...
The only solution I can think of is that the swallowed app space will be dynamic... and that's left for joe to solve...

lior2b · #43 Post by **lior2b** » Sat 11 Feb 2006, 01:57

I patched JWM so it will automatically recognize window changes... it works really good! It took me an hour just to get my self going, and I have to say that joe is a very talented programmer!

Anyway, I'm too lazy to post about it in joe's forums, I've edited two files:
events.c, swallow.c

Everywhere I changed something there is a comment with my nick.

Blinky now looks as a native and integrates seamlessly with Puppy!

Edit:The patch can be found here.

BarryK · #44 Post by **BarryK** » Sat 11 Feb 2006, 02:35

Lior,
Gee, you've been busy!

regarding JWM 1.4, note that I use a taskbar height of 26, less than the default.
...does this affect anything?
...I've got Blinky 0.5 running in the JWM 1.4 taskbar right now, looks okay.

...would it be possible to have a bit more contrast when the little screens
flash green? Maybe a brighter green?

Um, could you let Joe know about your patch?
http://www.joewing.net

lior2b · #45 Post by **lior2b** » Sat 11 Feb 2006, 10:46

The taskbar height doesn't affect anything, try this (with unpatched JWM) :
Open JWM with blinky swallowed but no internet connection. Connect.
What happens? nothing... the space is fixed and does not change...

My patch listens to window size changes and changes the tray to fit. Try it, compile JWM with my patch and try the above scenario...
Anyway, I'll notify joe.

Attaching a green blinky, better?

Lobster · #46 Post by **Lobster** » Sat 11 Feb 2006, 10:57

I tend to have the brightness very low on my TFT screen and so it is a good test. It works very nicely on this set up.

lior2b · #47 Post by **lior2b** » Sun 12 Feb 2006, 00:59

Letting you know: I won't be here for the next few days, I'll come back at thursday... I'll probably miss the big puppy2alpha opening, good luck!

lior2b · #48 Post by **lior2b** » Tue 21 Feb 2006, 00:42

There was a nasty bug with my name all over it

Thank you jeffrey for discovering it!
Fixed it, and finally had the time to implement it the way I wanted to.

I read about the clock problem - the problem is in JWM, and I'm pretty sure my patch fixes it... The problem is with the swallow implementation, and nothing in blinky can prevent it from happening... Barry, please try patching it and report...

BarryK · #49 Post by **BarryK** » Tue 21 Feb 2006, 13:01

Lior,
ha ha, we are over-lapping!
I have just uploaded the News page for Feb 20th, stating I was
going back to blinky 0.2patched, as I thought you were still
away.
But then I came onto the Forum and found you have been busy
and fixed it.
Actually, this overlap has partly come about because there was
an electrical storm at my place this afternoon. So I stayed off the internet.
The sky is still overcast but no rumbles.

Note, when the old 0.2patch version takes the two rectangles "down" when the interface goes down, the clock is unaffected.

Anyway, I'll test the latest Blinky and update the News page.

lior2b · #50 Post by **lior2b** » Tue 21 Feb 2006, 14:01

I was afraid you would release 1.0.8 without Blinky

Anyway:

Note, when the old 0.2patch version takes the two rectangles "down" when the interface goes down, the clock is unaffected.

Blinky 0.5.1 fixes it, so the bug no longer exists in 0.6 (1.0.8 beta has 0.5)!

But, I remind you JWM 1.4 has a bug that affects Blinky too, and in my opinion has to be patched before the release. The patch affects only the swallow mechanism, hence can not cause any trouble. If you can't remember what I'm referring to read this, this and this.

lior2b · #51 Post by **lior2b** » Tue 21 Feb 2006, 14:18

FUCKKKKKKKKKKKKKK
I've uploaded the wrong patch files, i thought I've uploaded swallow.c but I've uploaded swallow.h!
FUCKKK I'm not sure I backed up this... searching...

lior2b · #52 Post by **lior2b** » Tue 21 Feb 2006, 14:50

Damn I'm such an ass... I'm attaching the __real__ patch files.
Just replace these two files with the original ones, and compile.

Please tell me I made it for 1.0.8

BarryK · #53 Post by **BarryK** » Wed 22 Feb 2006, 10:31

Too late!
1.0.8 is already out.
Seems to be working fine. When the interface goes down, the clock stays there.
-- JWM unpatched.

Will upload the 1.0.8 announcement to the News page soon.

lior2b · #54 Post by **lior2b** » Wed 22 Feb 2006, 10:35

Too late for JWM's patch or for Blinky 0.6?

Edit: I've seen the news! Finally 1.0.8!
Please correct the typo in my last name (Lior Tubor -> Lior Tubi) in the announcement, thanks!

lior2b · #55 Post by **lior2b** » Wed 22 Feb 2006, 11:42

After seeing 1.0.8, some thoughts:
I saw you had set the Blinky width to 39px through .jwmrc. In the next Puppy release please include JWM's patch and don't set the width. Moreover, in Blinky 0.7 I plan to increase the padding around the computers so the tray won't be crowded, and to include an optional command line argument - background color. I saw that xload has it and I want Blinky to suit the JWM theme colors. I tried to dynamically get the tray color (meaning Blinky's parent window bg color) but no success (and I think it can't be done), so a command line argument is the solution.

lior2b · #56 Post by **lior2b** » Fri 24 Feb 2006, 03:41

* New Release - Blinky 0.7 codename "Irresistible" *
I've read about Puppy 1.0.9 and I couldn't resist releasing another Blinky

This release implements the stuff I described above, meaning:
(*) A little bit more padding
(*) Command line argument to determine background color (!)
Examples (taken from the README file):

Code: Select all

blinky -bg "red"
blinky -bg "LightSteelBlue"
blinky -bg "#FFCCCC"

So, for Puppy 1.0.9 the .jwmrc entry (assuming JWM is patched) should be:

Code: Select all

<Swallow name="blinky">
	blinky -bg "#E0E5E0"
</Swallow>

Irresitible Blinky now integrates flawlessly to the Puppy Desktop!

Two more things about JWM:
The author of JWM has replied my post and said that the patch will probably be in the next JWM release, yeah!

I'm attaching a patched JWM 1.4 binary, for you to try / replace the unpatched.
Insctructions:
1) Download jwm-1.4_patched.tar.gz and blinky-0.7.tar.gz
2) Open up rxvt and enter the directory for which you downloaded the files
3) To install enter this:

Code: Select all

tar -xzf blinky-0.7.tar.gz && tar -xzf jwm-1.4_patched.tar.gz && mv /usr/X11R6/bin/jwm /usr/X11R6/bin/jwm.unpatched && mv /usr/bin/blinky /usr/bin/blinky0.6 && mv jwm /usr/X11R6/bin/jwm && mv blinky-0.7/bin/blinky /usr/bin/blinky && rm -R blinky-0.7

4) Change .jwmrc from:

Code: Select all

<Swallow name="blinky" width="39">
	blinky
</Swallow>

To:

Code: Select all

<Swallow name="blinky">
	blinky -bg "#E0E5E0"
</Swallow>

5) Restart JWM (Start->Shutdown->JWM restart)

(*) Note: To uninstall (don't really see a reason but anyway) enter this:

Code: Select all

mv /usr/X11R6/bin/jwm.unpatched /usr/X11R6/bin/jwm && mv /usr/bin/blinky0.6 /usr/bin/blinky

Isn't that beautiful

(old)Puppy Linux Discussion Forum

(old)Puppy Linux Discussion Forum

Problem with Blinky