(old)Puppy Linux Discussion Forum

disciple wrote:Hey, has anyone else noticed this?:
If the volume is at 0% or 100%, scrolling the mouse wheel over the tray icon often does not have any effect. After left clicking on the icon and then clicking again to close the slider, scrolling over the icon always works. Also, if the volume is not at 0% or 100%, I think it always works.
It looks like a way to reliably trigger the problem is to disable the context menu and right-click twice on the icon to bring up the "full window" and close it again...
I'm wondering if it is anything to do with my tray or my GTK version or something - I'll see if I can investigate further.

vicmz wrote:Retrovol has never worked on my computer, does it work for others? From Lucid Puppy to the very latest development versions of Precise, Retrovol doesn't do anything to the volume level -- or at least not in the Intel- or AMD-powered desktop computers I've used. I always rely on the volume control of Gnome MPlayer and DeaDBeeF, who wants to make a scientific investigation to rise/low volume when all they wish at the moment is to enjoy a video or their favourite music? Now seriously, this is the kind of bugs that make some windoze users say "aahhh, LINUX is crappy!" It'd be great to find a solution.

666philb wrote: hi vicmz

right click on the retrovol tray icon and choose 'config window' then click on the 'hardware' tab and try changeing hw:0 to hw:1 or visa versa.....

any luck?

vicmz wrote:Retrovol has never worked on my computer, does it work for others? ...

L18L wrote:Glad for being able to control sound volume now

Henry wrote:
"That the curve is so crowded at the top is perhaps not so bad as the lack of a true mute."

It has a "true mute" as far as I can tell. Am I missing something, or are you?

"If anybody is interested in having it changed right now, there are only two lines of source code that would need adjusting. Otherwise, you'll have to wait until I get around to adding it proper, which is more work since I want it to be optional - I'm kind of busy lately so I might not work on it for a week or two. Also, this hasn't been tested thoroughly - it is possible that in some situations near the maximum and minimum volume levels you might have trouble getting it to completely max (or min) out. I will test that more rigorously when I implement it for real.

Anyway, the changes are to the alsa_classes.cpp file. The lines to change are 161 and 167, in the scale_out and scale_in functions.

Here is the original code: Code:
//this is used internally to scale a number to be from 0-100
int Element::scale_out(int num){
if(max-min==0){ return(num); }
return(ceil(100.0*(num-min)/(max-min)));
}
//this is the inverse of scale_out; it's used to take a 0-100 number and put it
//into the proper scale for the element to understand
int Element::scale_in(int num){
if(max-min==0){ return(num); }
return(floor((num*(max-min)/(100))+min));
}


And here is the modified code: Code:
//this is used internally to scale a number to be from 0-100
int Element::scale_out(int num){
if(max-min==0){ return(num); }
return(ceil(pow(100.0, (num-min)/(double)(max-min))));
}
//this is the inverse of scale_out; it's used to take a 0-100 number and put it
//into the proper scale for the element to understand
int Element::scale_in(int num){
if(max-min==0){ return(num); }
return(round((log(num)/log(100)*(max-min))+min));
}



And here is the diff, if you prefer that format: Code:
--- src/alsa_classes.cpp (revision 181)
+++ src/alsa_classes.cpp (working copy)
@@ -158,13 +158,13 @@
//this is used internally to scale a number to be from 0-100
int Element::scale_out(int num){
if(max-min==0){ return(num); }
- return(ceil(100.0*(num-min)/(max-min)));
+ return(ceil(pow(100.0, (num-min)/(double)(max-min))));
}
//this is the inverse of scale_out; it's used to take a 0-100 number and put it
//into the proper scale for the element to understand
int Element::scale_in(int num){
if(max-min==0){ return(num); }
- return(floor((num*(max-min)/(100))+min));
+ return(round((log(num)/log(100)*(max-min))+min));
}
//this will grab the highest value in the element
int Element::get(){

If you wanted some other scaling formula, these two functions are where you'd define it.

L18L wrote: Right klick > Config window > tab between main and hardware (don't see it in English at the moment) > 3rd row

change from wrong
32: Master Playback Volume
to
9:PCM Playback Volume
Apply

and sound volume becomes different

Glad for being able to control sound volume now

hi vicmz
using that
any luck?

vicmz wrote:Wow
Thank you

Now the BIG question is: if this is how Retrovol is supposed to work, why is Puppy using another setting as default? Or different CPUs have different settings?

vicmz wrote:

L18L wrote: Right klick > Config window > tab between main and hardware (don't see it in English at the moment) > 3rd row

change from wrong
32: Master Playback Volume
to
9:PCM Playback Volume
Apply

and sound volume becomes different

Glad for being able to control sound volume now

hi vicmz
using that
any luck?

Wow
Thank you

Now the BIG question is: if this is how Retrovol is supposed to work, why is Puppy using another setting as default? Or different CPUs have different settings?

disciple wrote:I think you have a weird sound card, or something is weird about your system - maybe the linux driver that is used for your chip doesn't quite know enough about it and thinks that it has controls that it really hasn't. With most cards "master playback" is the best choice.

disciple wrote:You might want to take that suggestion somewhere else where it is more likely to be seen...

• Three options for volume scaling - linear, logarithmic, exponential
• Auto-mute when set to 0%, can be optionally disabled
• Does not use the muted icon unless actually muted (note to themers: added a fifth icon for 0% but unmuted: audio-volume-none.png)
• No longer crashes if the soundcard is missing or misconfigured
• Now updates tray slider every second just like main-window sliders
• No more level resetting if you change the volume and then scroll on the tray icon
• No more getting stuck at 0% and 100%
• Now using own git repository at GitHub

No longer crashes if the soundcard is missing or misconfigured

terminal1 wrote:# retrovol
Control hw:0 open error: No such file or directory
Segmentation fault

terminal2 wrote:# alsaconf ##hit first dialog cancel to quit program
# lsmod | grep snd
snd_page_alloc 4765 0