Page 7 of 118
Posted: Fri 29 Feb 2008, 09:52
by ttuuxxx
hey plinej I just looked at your application and yes it looks promising, How about combining Pburn&Pvobcopy2 into 1 application add some bling "shaken not stirred" call it KCPP "Killer Copy Puppy Power" and make everybody happy, You do know most new users are from the Windows/Nero era right. And most people aren't happy unless they have bling and quality. Sometimes i think they pick bling over quality which is stupid, but true. Shit I even added all the KDE apps to "Inferno just to run K3B and k9copy. like over 100MB to make them happy.
What would really be nice is if you could make a K3B on gtk only no KDE, which I think could be possible, But Untried. Man you would get popular real quick in the Linux Land.
Well thanks for letting me dream for a moment, Excellent work both of you
really Puppy is sometime like Christmas, You ask Santa aka developers for a gift and then wait and see. Hoe Hoe merry Coding and have a happy kernel. LOL what the hell was i thinking typing that stuff, lolololol
Posted: Fri 29 Feb 2008, 23:20
by zigbert
Bling or
Bloat ???
Pburn can now
optional use a theme. Maybe also we should give some tweaks with a Pburn gtk2-theme. But...enough for today.
Sigmund
Posted: Fri 29 Feb 2008, 23:42
by ttuuxxx
Man thats sweet, excellent looking , just what the doctor was ordering.
When you try something it really does work out great.
I couldn't of done better myself:)
ttuuxx
P.s yes I'll for sure be using it from now on.
Posted: Fri 29 Feb 2008, 23:56
by MU
the source for gtklogfileviewer (main.c) has this line:
gtk_button_set_image (GTK_BUTTON(button1) , image1);
Simply comment it, then run "make" again.
To use an external picture, you had to replace:
Code: Select all
image1 = gtk_image_new_from_stock ("gtk-cancel" , GTK_ICON_SIZE_BUTTON);
with:
Code: Select all
image1 = gtk_image_new_from_file ("test.png");
A "test.png" must be in the same folder then.
I attach an archive with modified source and binary.
It includes additional patches, e.g. it now will now not run as background-process.
So it blocks a running script, so that you can easier request the exit-code (But I'm not shure if this is wanted here for pburn?).
And you must pass a windowtitle.
Usage:
./gtklogfileviewer /tmp/xerrs.log "stop" 80 100 700 200 "INFO"
See requests by Mikeb:
http://murga-linux.com/puppy/viewtopic.php?t=25477
Mark
Posted: Sat 01 Mar 2008, 00:47
by mikeb
Definate BLING....in fact SEXY...
...has my vote.....
as for bloat have you seen the size of nero for linux!!!!!!!
By the way I tried gtklogfileviewer with pburn and although its still not part of the main gui at least it functions well and looks better.
I tidied up the verify function a bit in relation to drawer opening and logging..might be helpful with further developements...
mike
Posted: Mon 03 Mar 2008, 09:19
by zigbert
I'm very pleased by your help here, Mike. Your verify code works perfect in Pburn, and have joined the rest of the code. However, it fails when burning multisession. Either we have to write our own diff-check, or just give verify-option when burning single session.
Have you looked at the iso-verifying?
When posting hacked files, it would be useful if you commented changed lines with #mikeb.
Thanks a lot
Sigmund
Posted: Mon 03 Mar 2008, 12:59
by mikeb
However, it fails when burning multisession. Either we have to write our own diff-check, or just give verify-option when burning single session.
Well for me it passes the last session as ok but fails on the previous sessions as they are only on disk...perhaps grep for the currently burned results using the burnlist entries..I'll have a fiddle with that one.
Plus generally perhaps some handling to simply return 'verify ok' if all verifies sucessfully.
Have you looked at the iso-verifying?
Not yet but burniso2cd compares the md5 checksum as a verify so perhaps use code from there?
When posting hacked files, it would be useful if you commented changed lines with #mikeb.
good point...I iz such a slob
By the way my method of showing/not showing the verify is a bit sloppy...the pmount method would be neater.
regards
mike
Posted: Mon 03 Mar 2008, 13:38
by zigbert
By the way my method of showing/not showing the verify is a bit sloppy...the pmount method would be neater.
I've restructured your code a bit. Here are the latest func_exec
Code: Select all
#!/bin/sh
export LOG="/tmp/pburn-log"
echo -e "\c" > /tmp/pburn-log
"$APPDIR"/func -logbox &
#---
#TMP=`cat /tmp/pburn-exec | grep cdrecord` #to get correct linespacing i Xdialog logbox --> slow render on older cpu
#sed -i -e "s%$TMP%$TMP | tr '\r' '\n' %g" /tmp/pburn-exec'
#---
while [ 1 ]; do #burn-again-loop
chmod 700 /tmp/pburn-exec
/tmp/pburn-exec >> $LOG 2>&1
TMP=$?
#define if info about iso-image should be shown
TXT_IMAGE="-"
if [ `find "$OUTDIR/Pburn.iso"` ]; then
TXT_IMAGE="
$LOC405 $OUTDIR"
fi
if [ $TMP != 0 ]; then
if [ $EJECT = true ]; then
eject $BURNDEV
fi
#ERROR
ERROR="<b>Unknown error.</b>"
if test "`cat $LOG | grep "No disk"`"; then ERROR="$LOC387"; fi
if test "`cat $LOG | grep "Cannot load"`"; then ERROR="$LOC388"; fi
if test "`cat $LOG | grep "Joliet"`"; then ERROR="$LOC392"; fi
if test "`cat $LOG | grep "No such device"`"; then ERROR="$LOC393"; fi
if test "`cat $LOG | grep "overburn"`"; then ERROR="$LOC394"; fi
if test "`cat $LOG | grep "No space left"`"; then ERROR="$LOC389"; rm "$ISOFILE"; fi
if test "`cat $LOG | grep "BLANK media"`"; then ERROR="$LOC397"; fi
if test "`cat $LOG | grep "next writable add"`";then ERROR="$LOC398"; fi
TXT1="$ERROR......$LOC399"
TXT2="$TXT_IMAGE"
. "$APPDIR"/box_ok
break
else
#finished
while [ 1 ]; do #verify-loop
if [ $BURN_DATA = true ] && [ ! "$SECTIONS" ]; then #it's a DATA single session, and verify works.
GUI_VERIFY="<button><input file icon=\"gtk-apply\"></input><label>$LOC409</label><action type=\"exit\">verify</action></button>"
fi
export finish_box="
<window title=\"Pburn $VERSION\" icon-name=\"gtk-cdrom\">
<vbox>
<frame $LOC406>
$SPLASH
<text use-markup=\"true\"><label>\"$LOC407\"</label></text>
<text><label>$TXT_IMAGE</label></text>
</frame>
<hbox>
<button>
<input file icon=\"gtk-cdrom\"></input>
<label>$LOC408</label>
<action type=\"exit\">repeat</action>
</button>
$GUI_VERIFY
<button>
<input file icon=\"gtk-quit\"></input>
<label>$LOC406</label>
</button>
</hbox>
</vbox>
</window>"
#show verify box if it is a DATA disc
I=$IFS; IFS=""
for STATEMENTS in $(gtkdialog3 --program=finish_box --center); do
eval $STATEMENTS > /dev/null 2>&1
done
IFS=$I
case $EXIT in
verify)
mkdir /tmp/verify 2>/dev/null
mount $BURNDEV /tmp/verify -t iso9660
echo -e "\n\n======================================================\n$LOC431...\n" >> $LOG
diff -s -r --speed-large-files /tmp/verify /tmp/pburn >> $LOG
echo -e "\n...$LOC432" >> $LOG
umount $BURNDEV
;;
repeat)
break
;;
*)
. "$APPDIR"/func -new
if [ $EJECT = true ]; then
eject $BURNDEV
fi
kill -9 `ps -eo pid,command | grep -i "pburn" | grep -i "gtklogfileviewer" | grep -v grep | awk '{print $1}'`
rm -f "$OUTDIR"/Pburn.iso > /dev/null 2>&1
rm -f "$OUTDIR"/pburn-audiocd.bin > /dev/null 2>&1 #cdrdao
rm -rf "$OUTDIR"/pburn_tmp > /dev/null 2>&1
exit
;;
esac
done
fi
done #repeat-action-loop
Posted: Mon 03 Mar 2008, 14:42
by mikeb
Ok
Thanks for passing that on
MIke
Posted: Mon 03 Mar 2008, 17:41
by mikeb
Code: Select all
diff -r --speed-large-files /tmp/verify /tmp/pburn | grep -v verify: >> $LOG
will only output errors, and errors from files that are only exist on the disk ie from a previous session will be ignored....so a good multisession burn would output nothing...
mike
Posted: Mon 03 Mar 2008, 18:09
by zigbert
great!!!
Posted: Mon 03 Mar 2008, 18:19
by mikeb
Goodly
by the way I had to change at around line 110 in func in the import_session section from
to
Code: Select all
mount $BURNDEV /tmp/pburn-mnt -t iso9660
mike
Posted: Mon 03 Mar 2008, 20:34
by zigbert
How to make a Pburn Theme
- Themes are put in /usr/local/pburn/themes/NAME_OF_THEME/
- You can freely use the size of images that you feel look best. (Buttons height should not be more than 63 pixels)
- Use *.png format.
- You can also specify a unique gtk-theme for Pburn main window. This is put inside /usr/local/pburn/themes/NAME_OF_THEME/gtk/
- If using same image in several dialogs, - make a symlink to save space.
See theme 'Pburn-original' for complete file list.
Download:
Pburn-original (84 kb).
Good luck!
Sigmund
Posted: Mon 03 Mar 2008, 20:59
by mikeb
Iso verifying
Here is a slightly modded version of the verify from burniso2cd...added stat -L option to work through symlink...written by kirk...
Code: Select all
ISOFILE="/tmp/pburn/boot.iso"
CDR="/dev/hdc"
if [ "$( md5sum $ISOFILE | cut -f 1 -d " " )" = "$(dd if=$CDR | head -c `stat -L --format=%s $ISOFILE` | md5sum | cut -f 1 -d " " )" ] ;then
xmessage -bg "#80ff80" -center -name "Pburn" -title "Burniso2cd: Burn Verify" -buttons "OKAY:10" "The burn has been verified as good!"
else
xmessage -bg "#ffc0c0" -center -name "Pburn" -title "Burn Verify" -buttons "OKAY:10" "The burn was not verified. "
fi
Have been testing as standalone script plus I don't have a dvd burner to test with. The disk does NOT need mounting.
On a side note, burn command breaks if there is a space in the path to the iso.
Mike
Posted: Mon 03 Mar 2008, 22:06
by zigbert
Mike
You are a hard working man!
I'll look at this in the morning.
It's late in Norway right now.
Good night
Sigmund
Posted: Tue 04 Mar 2008, 00:04
by ttuuxxx
zigbert wrote:How to make a Pburn Theme
Themes are put in /usr/local/pburn/themes/NAME_OF_THEME/image.png
Install the theme Pburn-original to see how that works.
You can freely use the size of images that you feel look best.
Use *.png format.
You can also specify a unique gtk-theme for Pburn. This is put inside /usr/local/pburn/themes/gtk/.
If using same image in several dialogs, - make a symlink to save space.
See theme Pburn-original for complete file list.
Theme:
Pburn-original (151 kb).
Good luck!
Sigmund
that sounds excellent and so easy
Posted: Tue 04 Mar 2008, 07:35
by zigbert
I have made a edit on the theme post. - Button images shoudn't be higher than 63 pixels.
Also MU helped out to change the radiobuttons in the main window. See this.
http://www.murga-linux.com/puppy/viewto ... 053#179053
Sigmund
Posted: Wed 05 Mar 2008, 08:53
by zigbert
Version 1.2.0 is uploaded. See main post.
Posted: Fri 07 Mar 2008, 06:53
by zigbert
I have tweaked the original theme. It mainly look the same, but now it is only 89kb compared with the old version of 152kb. To handle this tweak you need the new Version 1.2.1. see main post.
Posted: Fri 07 Mar 2008, 21:38
by mikeb
Hi Zigbert
something resembling the following is needed in func_exec just before
done #repeat-action-loop right at the end
Code: Select all
eject $BURNDEV
IMG="dialog-info"; FRAME="Repeat Burn"
TXT1="Please insert blank disk.
Press OK when ready."
. "$APPDIR"/box_ok
in order that the disk can be changed for repeat burns.
Haven't progressed with the iso verify as all my cd/rw's are past their useful life so not ideal for checking for good burns
..
Nice one for the verify implementation and skinning functionality...
ok, off to melt some silver.............
mike
also
added to func_blank
Code: Select all
fi
[u]export BURN=blank # to avoid verify message[/u]
if [ "$MEDIATYPE" = "CD" ];then
and amended in func_exec
Code: Select all
if [ $BURN_DATA = true && $BURN != "blank" ]; then #verify button
.....removes verify button etc when blanking without (as far as I can tell) other functions.[/code]