GtkDialog - tips

[misko_2083]

check this line in actions.c
This is how the actions are executed
https://github.com/01micko/gtkdialog/bl ... ons.c#L664

[wiak]

.

[MochiMoppel]

Certainly shouldn't be using #!/bin/sh if the code inside is actually using bashisms (even though that would still work on Puppy systems since /bin/sh is linked to bash there

Depends. My example would not work

- that can't of course be relied on.

Not sure what "that" refers to but it is true in any case: It can't be relied on that sh is linked to bash and it can't be relied on that sh linked to bash can process bash specific code.

[wiak]

Certainly shouldn't be using #!/bin/sh if the code inside is actually using bashisms (even though that would still work on Puppy systems since /bin/sh is linked to bash there

Depends. My example would not work

No, as you said, your example would need #!/bin/bash at top.

wiak

[wiak]

.

[fredx181]

Success! Thus far at least.
....
....
EDIT:
THE PROBLEM, is that, whilst I wish gtkdialog had been like that in the first case (i.e. not using the, generally unsafe, C system call like it does) much of gtkdialog we know probably will not work as we have come to expect since my modded version does not use /bin/sh -c and hence does not interpret the supplied <action> command as a string but rather as an actual command (if you see what I mean). So, for example, <action>echo $0 >/dev/tty</action> would not give you the result (output to the current terminal)

That's great wiak, looks like your "gtkwialog" could become a useful program !
I am mostly interested in what's required to change in existing scripts in case using your mod (and in case sh > dash or busybox). That looks like it's easier than with existing gtkdialog. As far as I can understand, the changes should be: bash -c <function_name> rather than just <function_name> ? (but probably not that only, I have the feeling).

Fred

[rcrsn51]

So "gtkwialog" could be added to Fred's repo as a separate item?

Then people who want to build new apps using it can do so, without worrying about side-effects on older gtkdialog apps.

Or people could gradually upgrade their gtkdialog apps to gtkwialog after proper testing.

----------------

[wiak]

So "gtkwialog" could be added to Fred's repo as a separate item?

Then people who want to build new apps using it can do so, without worrying about side-effects on older gtkdialog apps.

Or people could gradually upgrade their gtkdialog apps to gtkwialog after proper testing.

----------------

Yes, that will be possible.

wiak

[wiak]

.

[wiak]

.

[rcrsn51]

@wiak. Thanks.

Could you provide a quick list of the main changes needed to switch an app from gtkdialog to gtkwialog?

[wiak]

.

[MochiMoppel]

Quickest, is when /bin/sh still is link to bash then all you need is to change gtkdialog reference in your code to gtkwialog.

Can't confirm. This also requires <action>bash -c funcname</action>.

[wiak]

Quickest, is when /bin/sh still is link to bash then all you need is to change gtkdialog reference in your code to gtkwialog.

Can't confirm. This also requires <action>bash -c funcname</action>.

No, it doesn't. I'll recheck though. If your script is a bash script (i.e. starts with #!/bin/bash or wherever bash is) and your system has /bin/sh as a link to bash, you just need the usual <action>function_name</action>

[wiak]

@MochiMoppel:

See attached screenshot showing the code and result including just started up rox filemanager. No bash -c needed in this case. By the way, ignore it saying 'gtkdialog' in the code below, it's gtkwialog before name being changed.

I'm not saying there won't be other things that do need changed a bit (particularly if quoting involved). There may or may not be. Needs tested and any new rules documented.

wiak

[MochiMoppel]

I tried

Code: Select all

#!/bin/bash
testo () {
echo hello
};export -f testo

echo -n '
<button>
<action>testo</action>
</button>'| /root/tmp/gtkwialog_prealpha32 -s

Would work with original gtkdialog

[wiak]

.

[rcrsn51]

Quickest, is when /bin/sh still is link to bash then all you need is to change gtkdialog reference in your code to gtkwialog.

Can't confirm. This also requires <action>bash -c funcname</action>.

I see the same problem. And this doesn't work either.

Code: Select all

<action>bash -c  funcname &</action>

[wiak]

.

[MochiMoppel]

The code Mochi... posted worked perfectly on my XenialDog64 system with gtkwialog...64 version.

Mochi used gtkwialog_prealpha32 ...