Puppy Linux Discussion Forum Forum Index Puppy Linux Discussion Forum
Puppy HOME page : puppylinux.com
"THE" alternative forum : puppylinux.info
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

The time now is Sun 21 Oct 2018, 15:10
All times are UTC - 4
 Forum index » Advanced Topics » Additional Software (PETs, n' stuff) » Filesystem
ROX-Filer 2.11 patched
Post new topic   Reply to topic View previous topic :: View next topic
Page 2 of 4 [60 Posts]   Goto page: Previous 1, 2, 3, 4 Next
Author Message
woodenshoe-wi

Joined: 28 Jul 2017
Posts: 78
Location: Wisconsin

PostPosted: Sun 29 Apr 2018, 00:50    Post subject:  

New version again, I tried to make a sfs but I couldn't get it to load over the main sfs so I repacked it as a pet with just the AppDir and desktop file. This one will not overwrite any settings, but should not be used for woof builds.
Edit: Newer versions posted later.

I was able to fix the "copy/paste" functionality. The problem was that the clipboard was "set" during initialization instead of when actually doing a "copy" or "cut", so it would stop working as soon as another program used the clipboard. Once I moved the "set" function to the proper place the strange behavior stopped.

For debugging I wrote some scripts that use xclip to copy and paste from the command line, I don't know if anyone else might find them useful?

g-copy
Code:
#!/bin/bash

case $@ in
   -h|-*help|-*usage)
      echo "Usage: $(basename $0) <files to copy>"
      exit 0
      ;;
   "")
      echo "Usage: $(basename $0) <files to copy>"
      exit 1
      ;;
esac

clipboard="copy
"

for one_arg in "$@"
do
   #echo "X${one_arg}X"

   filename=$(realpath "${one_arg}")
   #echo "${filename}"

   clipboard="${clipboard}file://${filename}
"
done

echo "${clipboard}" | xclip -i -selection clipboard -t x-special/gnome-copied-files


g-cut
Code:
#!/bin/bash

case $@ in
   -h|-*help|-*usage)
      echo "Usage: $(basename $0) <files to cut>"
      exit 0
      ;;
   "")
      echo "Usage: $(basename $0) <files to cut>"
      exit 1
      ;;
esac

clipboard="cut
"

for one_arg in "$@"
do
   #echo "X${one_arg}X"

   filename=$(realpath "${one_arg}")
   #echo "${filename}"

   clipboard="${clipboard}file://${filename}
"
done

echo "${clipboard}" | xclip -i -selection clipboard -t x-special/gnome-copied-files


and g-paste
Code:
#!/bin/bash

carriage_return=$(echo -ne '\r')

filelist=$(xclip -o -selection clipboard -t x-special/gnome-copied-files)

paste_mode=$(echo "${filelist}" | head -n 1)
#echo "X${paste_mode}X"

while read line
do
   line=${line//${carriage_return}/}
   #echo "X${line}X"

   if [ "${line}" = "${paste_mode}" ]; then
      continue
   fi

   filename=${line#file:\/\/}
   #echo "${filename}"

   if [ -e "${filename}" ]; then
      if [ "${paste_mode}" = "cut" ]; then
         mv -f "${filename}" .
      else
         cp -af --no-preserve=context,links "${filename}" .
      fi
   else
      echo "Error parsing line: ${line}"
   fi

done <<< "${filelist}"


Pets that are suitable for woof builds are also available,
Edit: Newer versions posted later.
But as before, be warned that they will reset your desktop background, overwrite your pin-board and possibly other unwanted changes... They are meant for woof builds. Also @peebee please DON'T upload to ibiblio unless or until you are confident that they work properly. I am posting them for more thorough testing.

Edit: Added 64 bit standalone version.
Edit2: Removed old links, newer versions posted later.

Last edited by woodenshoe-wi on Fri 18 May 2018, 17:01; edited 2 times in total
Back to top
View user's profile Send private message 
Puppyt

Joined: 09 May 2008
Posts: 838
Location: Gatton, Queensland

PostPosted: Mon 14 May 2018, 00:07    Post subject:  

Thanks so much woodenshoe-wi - rox column management active in TahrPup64 6.0.6. Was rehashing an old grumble on a recent thread, and your pet has salved a sore point in Rox usability. Cheers!
Re: How do I modify ROX detail columns?

UPDATE: Sorry, I have to qualify my test as a partial success only. I haven't tested copy'n'paste which I see was your main concern with your patch. However, I got a bit giddy with the detail view column change functionality, which in my TahrPup64 version had been locked into a useless Name/Permissions/Owner/Group/Type/Size/Last modified... format. Who needs Permissions/Owner/Group in Puppy??? Wish there was some way to eliminate those columns entirely.
Anyway, while your patch is great for shifting the ordered sequence of columns in any Rox window - the changes aren't persistent between Rox windows, and are not persistent on reboots. Any hope for tweaking your patch just a bit further for permanence?

_________________
Search engines for Puppy
http://puppylinux.us/psearch.html; Google Custom Search; others TBA...
Back to top
View user's profile Send private message Visit poster's website 
woodenshoe-wi

Joined: 28 Jul 2017
Posts: 78
Location: Wisconsin

PostPosted: Mon 14 May 2018, 12:21    Post subject:  

Well, first I want to make it clear that I didn't write the movable columns patch. I cherry picked a commit by JakeSFR who gave the credit to forum users Otter & Rocket.
https://github.com/woodenshoe-wi/rox-filer/commit/4befe7632dfb2b37c2e8dcb50198d620f7735bc4

The copy and paste functionality was actually something I saw in a GitHub fork of rox-filer by dtomas https://github.com/dtomas/rox-filer
It did not look like it had been merged into the jun7 fork, but it would solve a complaint that rox-filer lacks proper copy and paste support. When I added "cut to clipboard" support I accidentally added a segfault, which I fixed when I found it, and I also made changes to the original implementation of "copy and paste" to fix problems I found with it.

My original motivation for making these changes was to get the "overwrite if newer" check box working properly because there were two camps of ROX users, those including myself who were happy with the old behavior of being prompted about every overwrite, and those that found the prompts irritating and preferred to use a newer version of ROX that didn't prompt when overwriting regardless of whether the overwriting file was newer or older than the file that was being overwritten.

When I was working on this I also noticed that the function that handled moving files and directories had diverged from the function that copies files and directories so I rewrote the "move" function to more closely match the "copy" function and now it should be possible to "merge" directories when moving them just like when copying them.

Because of all these changes and the potential for bugs and segfaults I would like people to test this version before it would be made a default version in woof builds, but I am not sure how to go about getting it tested. There are no "testing" version package lists, once it would be uploaded to ibiblio it could end up being the default version which would be bad if it had any serious bugs.
Back to top
View user's profile Send private message 
woodenshoe-wi

Joined: 28 Jul 2017
Posts: 78
Location: Wisconsin

PostPosted: Fri 18 May 2018, 16:57    Post subject:  

New version again. These are the standalone versions that will not overwrite any settings, but should not be used for woof builds.

Edit: These were buggy, newer versions posted later.

This version makes NO changes to rox column management, but instead adds the feature that when a directory is open in a filer window and the directory no longer exists because it is unmounted or deleted the filer window will be automatically closed.

Pets that are suitable for woof builds are also available,
Edit: These were buggy, newer versions posted later.
But as before, be warned that they will reset your desktop background, overwrite your pin-board and possibly other unwanted changes... They are meant for woof builds. Also @peebee please DON'T upload to ibiblio unless or until you are confident that they work properly. I am posting them for more thorough testing.

It should also be possible to use my gitlab repo for test woof builds by

    1. adding "z|https://gitlab.com/woodenshoe-wi/petbuilds-out/raw/master/puppylinux/Packages-puppy-common32-woodenshoe|z" or "z|https://gitlab.com/woodenshoe-wi/petbuilds-out/raw/master/puppylinux/Packages-puppy-common64-woodenshoe|z" as appropriate to PKG_DOCS_PET_REPOS in DISTRO_PET_REPOS,

    2. adding "z|https://gitlab.com/woodenshoe-wi/petbuilds-out/raw/master/puppylinux|Packages-puppy-*-woodenshoe" to PET_REPOS in DISTRO_PET_REPOS

    3. and adding "Packages-puppy-common32-woodenshoe" or "Packages-puppy-common64-woodenshoe" as appropriate to PACKAGELISTS_PET_ORDER in DISTRO_PET_REPOS.

All 3 steps are needed.

Starting with version 6, the name that has to be added to DISTRO_PKGS_SPECS is no longer "rox-filer-woodenshoe", just the standard "rox-filer".

Last edited by woodenshoe-wi on Mon 02 Jul 2018, 01:26; edited 2 times in total
Back to top
View user's profile Send private message 
woodenshoe-wi

Joined: 28 Jul 2017
Posts: 78
Location: Wisconsin

PostPosted: Sun 20 May 2018, 01:35    Post subject:  

Version 2 was buggy, this new version can also configure which columns are visible in "List View".

Edit: Newer versions posted later.

Pets that are suitable for woof builds are also available,
Edit: Newer versions posted later.
But as before, be warned that they will reset your desktop background, overwrite your pin-board and possibly other unwanted changes... They are meant for woof builds. Also @peebee please DON'T upload to ibiblio unless or until you are confident that they work properly. I am posting them for more thorough testing.

Last edited by woodenshoe-wi on Thu 24 May 2018, 01:50; edited 1 time in total
Back to top
View user's profile Send private message 
davids45


Joined: 26 Nov 2006
Posts: 1157
Location: Chatswood, NSW

PostPosted: Wed 23 May 2018, 23:33    Post subject: Pinboard icon text
Subject description: A couple of issues
 

G'day woodenshoe-wi,

In response to your post on the Rox poll thread Smile , I had just tried your latest .pet for your Rox in a BionicPup1805-2+Sc64bit-kernel Frugal.

The new Rox column adjustability is better - I deleted the never-been-used 'Permissions', 'Owner' and 'Group' columns (screenshot).

This Pup was already fully apped with my apps-links sfs and the pinboard icon labels edited by me, these apps having been dragged as .desktop files from /usr/share/applications/ so I remove '.desktop' and sometimes shorten what's left to fit under the icon.

1) with the new Rox, no .desktop to worry about but some application icon labels became too long and overlapped text of adjacent icons (screenshot)

2) when I tried to edit the too-long labels, I couldn't with your Rox. This may be something due to these being links to my data partition, not a 'normal' file on my frugals partition?

Can I edit something to shorten the over-long labels before they're being loaded onto the pinboard?

I found nothing else an issue with some quick tests with your Rox but have reverted to my previous savefile with its older Rox version and icon-text-editable pinboard (screenshot).

Happy to try anything else when I can.

Thanks for your work with Rox,

David S.
newRox-details-columns.jpg
 Description   unwanted/unused columns gone from new Rox details window
 Filesize   75.24 KB
 Viewed   484 Time(s)

newRox-details-columns.jpg

newRox-pinboard.jpg
 Description   application icon labels (some) too long and overlapping, which I could not edit away with the new Rox.
 Filesize   117.72 KB
 Viewed   484 Time(s)

newRox-pinboard.jpg

normal-pinboard-icon-labels.jpg
 Description   pre-new-Rox pinboard with application icon labels after normal removal of '.desktop' - works with 'old' Rox
 Filesize   113.33 KB
 Viewed   491 Time(s)

normal-pinboard-icon-labels.jpg

Back to top
View user's profile Send private message 
woodenshoe-wi

Joined: 28 Jul 2017
Posts: 78
Location: Wisconsin

PostPosted: Thu 24 May 2018, 01:48    Post subject:  

Thank you for testing davids45, I don't normally link .desktop files to my pinboard so I wouldn't have found the bug by myself.

Looking into the problem it seems that when the feature to use the name from .desktop files was added it would always override any user edits.

Here are new pets with a fix applied:
Edit: Newer versions posted later.

Pets that are suitable for woof builds are also available,
32 bit version https://gitlab.com/woodenshoe-wi/petbuilds-out/tree/master/puppylinux/pet_packages-common32
64 bit version https://gitlab.com/woodenshoe-wi/petbuilds-out/tree/master/puppylinux/pet_packages-common64
But as before, be warned that they will reset your desktop background, overwrite your pin-board and possibly other unwanted changes... They are meant for woof builds.

Last edited by woodenshoe-wi on Sun 17 Jun 2018, 19:35; edited 1 time in total
Back to top
View user's profile Send private message 
recobayu


Joined: 15 Sep 2010
Posts: 309
Location: indonesia

PostPosted: Mon 28 May 2018, 20:23    Post subject:  

Thank you, woodenshoe-wi.
I download your rox standalone and common. I install it on bionicpup. I got error on common's rox. I can not click on toolbar and i can not right click. But it does not happen with rox standalone in my bionicpup.
I am very happy because now i can make new directory by clicking on '+' toolbar. Also i can hide the unused column in list view.

I also thank you. Because I can copy-paste multiple file with yor rox-filer.

I still have problem when i will select multiple file by mouse (block by click and drag) in list view mode. I must choose the right coordinate (usually a line between two file) so i can block it. Could it be more easier as icon view does?


But I say thank you again for your hard work.
Smile
Back to top
View user's profile Send private message 
woodenshoe-wi

Joined: 28 Jul 2017
Posts: 78
Location: Wisconsin

PostPosted: Tue 29 May 2018, 21:06    Post subject:  

recobayu wrote:
I got error on common's rox. I can not click on toolbar and i can not right click. But it does not happen with rox standalone in my bionicpup.


I can reproduce the problem you describe, restarting the X server fixes it for me. The strange thing is that I make the "standalone" version by deleting the files in /etc, /root and the /usr/local/bin/rox script from the "common" pet.

Maybe something is wrong with one of the config files in the petbuild template. The "common" pets are meant for woof builds, and the standalone pets are meant for installing in a running pup. Other than the configuration files they are identical.

I have an idea to make selecting files in list view easier by only allowing the icon and name columns to drag items, but I have to solve the "Attempt to paste empty selection!" warning first. So I won't be posting anything to test until I get this figured out.

In the meantime you could try holding down the CTRL key and clicking on each item you want to select. Time consuming, but maybe more reliable than clicking in just the right place?
Back to top
View user's profile Send private message 
Smithy


Joined: 12 Dec 2011
Posts: 934

PostPosted: Tue 12 Jun 2018, 05:14    Post subject:  

Hello woodenshoe, is there somewhere in your code to:

1. Remove the Copy dialogue completely (the shift+Ctrl+C one)
2. Rename Copy to Clipboard just to Copy.
3. Rename Cut to Clipboard just to Cut.
4 Make the delete dialogue operate with the Delete button on keyboard
as opposed to the laborious Shift+Ctrl+X
5. Rename Paste to Clipboard to just Paste.

6. And finally have them grouped in the same area as the rename and delete section.

Been testing those items and they are rock solid, but just would like to remove the duplication (Copy) and move them right next to each other to slim down the right click a bit.
woodenshoe rox1.png
 Description   
 Filesize   106.22 KB
 Viewed   294 Time(s)

woodenshoe rox1.png

Back to top
View user's profile Send private message 
step

Joined: 04 May 2012
Posts: 1090

PostPosted: Tue 12 Jun 2018, 11:23    Post subject:  

Hi Smithy, two things you asked about, renaming a menu item and changing its hot key, can be done also without changing the source code. Of course, changing the source code is another way.
I tested these methods on Fatdog64 ROX-Filer, I don't know if the version in this thread behaves the same way, but my guess is that it does.

To change a hotkey select (don't click) the menu option that you want to change and press the key you want for it. For instance, the picture you posted is exactly at the right spot for changing Ctrl+Shift+C to F5. Just press Del once (to free Ctrl+Shift+C) and press F5 (to assign F5). You should see the menu entry change to "Copy... (F5)".

Changing the text of menu entries is more complicated, but achievable. The gist of it is to add a custom translation file inside the ROX-Filer application folder, for your case, exactly adding file /usr/local/apps/ROX-Filer/Messages/en/LC_MESSAGES/ROX-Filer.mo. How to create ROX-Filer.mo. That's the more complicated part, if you have no previous experience with translating Puppy Linux. PM me if you're interested. No offense taken if you aren't.

_________________
Fatdog64-721|+Packages|Kodi|Findnrun|+forum|gtkmenuplus

Last edited by step on Tue 12 Jun 2018, 17:07; edited 1 time in total
Back to top
View user's profile Send private message 
woodenshoe-wi

Joined: 28 Jul 2017
Posts: 78
Location: Wisconsin

PostPosted: Tue 12 Jun 2018, 11:46    Post subject:  

Smithy wrote:

1. Remove the Copy dialogue completely (the shift+Ctrl+C one)

I use the Copy dialogue to make backup copies of files that I am going to edit, so I am not willing to remove it but I could rename it to Duplicate to free up the Copy name. The Rename dialogue is based on the Move dialogue so Duplicate would be the equivalent.

Smithy wrote:

4 Make the delete dialogue operate with the Delete button on keyboard
as opposed to the laborious Shift+Ctrl+X

I would love to do that but I can't figure out how to get GTK to assign the Delete button as a shortcut from the source code. Sad

Smithy wrote:

6. And finally have them grouped in the same area as the rename and delete section.

As long as you are OK with Paste staying where it is that sounds like a plan. I will work on it when I have some more time, so it won't be right away.
Back to top
View user's profile Send private message 
step

Joined: 04 May 2012
Posts: 1090

PostPosted: Tue 12 Jun 2018, 17:21    Post subject:  

woodenshoe-wi wrote:

Smithy wrote:

4 Make the delete dialogue operate with the Delete button on keyboard
as opposed to the laborious Shift+Ctrl+X

I would love to do that but I can't figure out how to get GTK to assign the Delete button as a shortcut from the source code. Sad

In my copy of the source code, the shortcut key is assigned in menu.c
Code:

{">" N_("Copy..."),      "<Ctrl>C", file_op, FILE_COPY_ITEM, "<StockItem>", GTK_STOCK_COPY},

If changing it there doesn't work then it could be set in a configuration file, either in the user's or XDG's configuration directories. In Fatdog64 those are ~/.config.mine/rox.sourceforge.net/ROX-Filer/menus2 and /etc/xdg/rox.sourceforge.net/ROX-Filer/menus2 respectively. My user's menu entry for copy is
Code:

(gtk_accel_path "<filer>/File/Copy..." "F5")

which assigns F5 and overrides menu.c

_________________
Fatdog64-721|+Packages|Kodi|Findnrun|+forum|gtkmenuplus
Back to top
View user's profile Send private message 
Smithy


Joined: 12 Dec 2011
Posts: 934

PostPosted: Tue 12 Jun 2018, 19:42    Post subject:  

Hi step, woodenshoe, first of all, reading through the information in both of your posts, I was just wondering if rox filer had a script or suchlike, where I could chop for example the copy line out at line number xx and shift the text a bit. Clearly not, looking inside.

I only compile the odd driver in a blue moon and those lc translations and .mo files down in the bowels of puppy I just have a quick look to make sure that apps have a bit of internationalisation if I'm making one.

I only wanted to do that for a user perspective copy, (even though this version is in final music2go sfs that I put together).

I realise that probably loads of puppy devs and users rely on the Shift+Ctrl+C and probably other key commands, so I didn't mean for you to change your official version Smile

If the delete key eventually becomes delete that will be great, the rest of my bullet points are really just cosmetic and a lot of the time I am ctrl c, ctrl x and ctrl v and of course...delete.

Actually duplicate could be a good idea woodenshoe, sort of makes sense.

I would say this rox filer makes things about 50% faster than the old drag and dropper that we have had to live with for years.. and got rid of the glipper thing on the taskbar.
Back to top
View user's profile Send private message 
woodenshoe-wi

Joined: 28 Jul 2017
Posts: 78
Location: Wisconsin

PostPosted: Wed 13 Jun 2018, 00:50    Post subject:  

@step I knew where the key binding was set but I couldn't figure out how to tell GTK to use the 'Delete' key. I had tried "<Del>" and "<Delete>" but it wouldn't recognize it. Somehow your post inspired me to try "Delete" and success!. I have the 'Delete' key assigned to the 'Delete' dialogue!

Smithy wrote:
I realise that probably loads of puppy devs and users rely on the Shift+Ctrl+C and probably other key commands, so I didn't mean for you to change your official version Smile

No... actually the original key binding for the old 'Copy' was Ctrl+C but I changed it to Shift+Ctrl+C because I wanted to use Ctrl+C for 'Copy to clipboard'. I think I will make Shift+Ctrl+C the key binding for 'Duplicate'.

Maybe I will have time to make a release this weekend.
Back to top
View user's profile Send private message 
Display posts from previous:   Sort by:   
Page 2 of 4 [60 Posts]   Goto page: Previous 1, 2, 3, 4 Next
Post new topic   Reply to topic View previous topic :: View next topic
 Forum index » Advanced Topics » Additional Software (PETs, n' stuff) » Filesystem
Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Powered by phpBB © 2001, 2005 phpBB Group
[ Time: 0.1357s ][ Queries: 15 (0.0175s) ][ GZIP on ]