Puppy Linux Discussion Forum

[L18L]

[step]

@jamesbond, I think I found a bug. Attached an md file to reproduce the issue. Essentially, when a line starts with [2] and includes matching brackets the text between [2] and the brackets included disappears. Version 2016.02.04 built on Thu Feb 4 07:09:52 2016.

[step]

@jamesbond, there's another issue concerning fenced code blocks and translations. I just realized that mdview --po doesn't output the text inside fenced blocks. On one hand that makes sense - it's source code after all - on the other hand it is a problem, because that text becomes invisible to the translation process, so it's hard to realize that it even exists before deciding if it should be translated or not.

There are valid cases for using fenced blocks for text other than source code, which should therefore be translated. So I'm proposing a work-around which I think doesn't break the fenced block syntax.

[step]

@jamesbond, here's another test case for the bug reported two posts above

[step]

@jamesbond

[L18L]

[step]

Hi L18L, thanks for your help. Your work-around shows that mdview can create correct output when "\[2\]" replaces "[2]" in the example above. This is useful, but backslashes shouldn't be needed in a common markdown implementation, so I think mdview still needs to be fixed about this problem.

As far as I know, in markdown brackets immediately followed by parens (round brackets) introduce a link label and its link target, like so:
[label](target)
where the target can be a local file or a URL.

This bug concerns the case where there is extra text between the closing square bracket and the opening round bracket, like so:
[2] some (text)

It should not produce a link with 2 as the label and "some (text)" as the target. It should produce just the text "[2] some (text)".

wikipedia states that a markdown standard doesn't exist. However, most common markdown implementations render "[2] some (text)" as text and not as a link, unlike mdview.

You can test several markdown engines at once by visiting this link: http://johnmacfarlane.net/babelmark2/?text=%5B2%5D+some+(text)%0A%0A%5B2%5D(target)

(apparently if I wrap the above URL inside url bbcode this post renders as an empty box)

[L18L]

[step]

[step]

@jamesbond, for your consideration, here is a proposed patch for the text links issue I reported earlier. It affects function egg_markdown_to_text_line_formatter_links. Note: I didn't patch image links, function egg_markdown_to_text_line_formatter_image, in a similar fashion, because in practical use I don't expect this issue to occur for image links.

The patch file is made against the source code already patched for code blocks. A markdown test file is attached.

I should make clear that this patch doesn't concern so-called reference-style links, which I don't think mdview supports. It's a patch for regular text links.

[jamesbond]

step, all patches applied (both codeblock-gettext and text-links patch): https://chiselapp.com/user/jamesbond/repository/mdview3/timeline

Thank you.

[01micko]

In the very latest build (recently pushed to petbuilds) everything seems to be working fine - but I have a feature request.

The files from puppylinux.com (which are in markdown format - converted to html server side) open fine on my local machine - but if there is a wide image it can't be viewed (re the timeline). I wonder if it is feasible to add a horizontal scrollbar? Mind you, this is probably beyond the scope of the project so I understand if you'd rather keep it simple.

[jamesbond]

[01micko]

[Sailor Enceladus]

For some reason, mdview doesn't seem to show this md file at all. Viewing it in Leafpad or in that link (with Firefox) works ok.