Puppy Linux Discussion Forum Forum Index Puppy Linux Discussion Forum
Puppy HOME page : puppylinux.com
"THE" alternative forum : puppylinux.info
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

The time now is Thu 17 Apr 2014, 23:04
All times are UTC - 4
 Forum index » Advanced Topics » Puppy Projects
Idea: adopt ROX-Filer
Moderators: Flash, JohnMurga
Post new topic   Reply to topic View previous topic :: View next topic
Page 2 of 4 [46 Posts]   Goto page: Previous 1, 2, 3, 4 Next
Author Message
sc0ttman


Joined: 16 Sep 2009
Posts: 2363
Location: UK

PostPosted: Thu 10 Mar 2011, 20:19    Post subject:  

why not just fork it? to a new project called "PuppyROX" or something...

I'm sure if iguleder, amigo or others post a few HOW TOs on using git, finding, making or applying patches, etc, then there would be a number of Puppy users who would contribute what they can, as usual.

IMHO, it would be nice to have a thread on this forum about updating "PuppyROX" - showing the patches that had been applied, the patches that are still in testing (needing improvements), etc..

There's no reason we couldn't also keep pace with the standard ROX, as iguleder says updates are sparse....

If "PuppyROX" is good, it will probably go into Puppy, to be used instead of ROX, if not, it won't. What's the controversy?

My personal preferences for ROX:

I'd like to see ROX produce a nicer set of desktop icons - without that border which appears when you click on an icon, maybe a translucent mask instead? This would match the way other, 'prettier' desktop systems work (thunar, etc)..

_________________
Akita Linux, VLC-GTK, Pup Search, Pup File Search
Back to top
View user's profile Send private message 
Dougal


Joined: 19 Oct 2005
Posts: 2505
Location: Hell more grotesque than any medieval woodcut

PostPosted: Fri 11 Mar 2011, 17:08    Post subject:  

sc0ttman wrote:
My personal preferences for ROX:

I'd like to see ROX produce a nicer set of desktop icons - without that border which appears when you click on an icon, maybe a translucent mask instead? This would match the way other, 'prettier' desktop systems work (thunar, etc)..

From pinboard.c:
Code:
/* The size of the border around the icon which is used when winking */
#define WINK_FRAME 2

and later
Code:
   gtk_container_set_border_width(GTK_CONTAINER(pi->win), WINK_FRAME);
   g_signal_connect(pi->win, "expose-event", G_CALLBACK(draw_wink), pi);

and later on you have
Code:
/* Put a border around the icon, briefly.
 * If icon is NULL then cancel any existing wink.
 * The icon will automatically unhighlight unless timeout is FALSE,
 * in which case you must call this function again (with NULL or another
 * icon) to remove the highlight.
 */
static void pinboard_wink_item(PinIcon *pi, gboolean timeout)
and also
Code:
static gint draw_wink(GtkWidget *widget, GdkEventExpose *event, PinIcon *pi)
{
   gint x, y, width, height;

   if (current_wink_icon != pi)
      return FALSE;

   x = widget->allocation.x;
   y = widget->allocation.y;
   width = widget->allocation.width;
   height = widget->allocation.height;

   gdk_draw_rectangle(widget->window,
         pi->widget->style->white_gc,
         FALSE,
         x, y, width - 1, height - 1);
   gdk_draw_rectangle(widget->window,
         pi->widget->style->black_gc,
         FALSE,
         x + 1, y + 1, width - 3, height - 3);

   return FALSE;
}

So I'm guessing white_gc and black_gc are the colours you care about (defined in struct _GtkStyle in /usr/include/gtk-2.0/gtk/gtkstyle.h), while /usr/include/gtk-2.0/gdk/gdkdrawable.h tells us:
Code:
void gdk_draw_rectangle (GdkDrawable      *drawable,
          GdkGC            *gc,
          gboolean          filled,
          gint              x,
          gint              y,
          gint              width,
          gint              height);

So it will appear you only need one rectangle and you just change the third variable from FALSE to TRUE in order for it to be filled.

All written in the Queen's English...

So you probably end up with something like
Code:
--- rox-filer/ROX-Filer/src/pinboard.c   2010-08-21 20:55:22.000000000 +0800
+++ rox-filer/ROX-Filer/src/pinboard.c.mod   2011-03-11 22:08:43.686079623 +0800
@@ -1164,12 +1164,8 @@
 
    gdk_draw_rectangle(widget->window,
          pi->widget->style->white_gc,
-         FALSE,
+         TRUE,
          x, y, width - 1, height - 1);
-   gdk_draw_rectangle(widget->window,
-         pi->widget->style->black_gc,
-         FALSE,
-         x + 1, y + 1, width - 3, height - 3);
 
    return FALSE;
 }


Or so I presume (this is untested).

Note that you might want to replace white_gc with something else relating to the gtk theme. You might want to look here and here. ('Though you might as well just change from the deprecated gdk_draw_rectangle to using Cairo... look here for an example.)

_________________
What's the ugliest part of your body?
Some say your nose
Some say your toes
But I think it's your mind
Back to top
View user's profile Send private message 
Makoto


Joined: 03 Sep 2009
Posts: 1722
Location: Out wandering... maybe.

PostPosted: Fri 11 Mar 2011, 18:25    Post subject:  

Hmm... is there, perhaps, an easier way of selecting a large group of files without Ctrl-clicking (or middle-mouse button-clicking) on each file, one by one... or in those rare instances when I'm at the end of the list and can draw a rectangle around the files?

I wouldn't really know how difficult it would be to implement if the behavior isn't already there, though. Sad

_________________
[ Puppy 4.3.1 JP, Frugal install | 1GB RAM | 1.3GB swap ] * My Pidgin Builds for Puppy 4.3.1+
In memory of our beloved American Eskimo puppy (1995-2010) and black Lab puppy (1997-2011).
Back to top
View user's profile Send private message 
Flash
Official Dog Handler


Joined: 04 May 2005
Posts: 10662
Location: Arizona USA

PostPosted: Sat 12 Mar 2011, 00:27    Post subject:  

Makoto, if the list of files is contiguous it is easy to draw a rectangle around them. Just switch to ROX's "Extra details" view first. Is that what you mean? Or do you mean where there are unwanted files and folders mixed in with the list as it is shown in ROX's "Extra details" view?
Back to top
View user's profile Send private message 
Makoto


Joined: 03 Sep 2009
Posts: 1722
Location: Out wandering... maybe.

PostPosted: Sat 12 Mar 2011, 01:33    Post subject:  

I have Extra Details as my normal view, though I don't really care much for the draw-a-box method - I usually have mediocre luck with it. Most of the time, I'll end up accidentally carrying a file around, instead. Smile (It only works every time for me if I start drawing the box off the bottom of the file list, really. Unless I'm doing something wrong... and probably am.)

Of course, I'm also long since used to the Windows Explorer way of doing it, too (didn't care for the box-drawing method there, either Embarassed ) - click on the first file, scroll down to the end file, hold down Shift and click on the ending file to select all of the files between them. Neutral

_________________
[ Puppy 4.3.1 JP, Frugal install | 1GB RAM | 1.3GB swap ] * My Pidgin Builds for Puppy 4.3.1+
In memory of our beloved American Eskimo puppy (1995-2010) and black Lab puppy (1997-2011).
Back to top
View user's profile Send private message 
sc0ttman


Joined: 16 Sep 2009
Posts: 2363
Location: UK

PostPosted: Sat 12 Mar 2011, 08:21    Post subject:  

Nice Dougal..

Another issue I thought of... I have ROX desktop using double click for icons. If you single click on an icon, it is highlighted with the translucent mask. But how would we add the feature of clicking on the desktop (not on another icon) to remove focus from the highlighted desktop icon?


Also, if you have double click enabled for ROX file manager navigation as well, you will see that when you click once on a file/folder (to select it), holding shift and using the cursor keys does not make ROX highlight the next or previous files - you cannot use the keyboard to highlight multiple files.

I personally like using the keyboard, especially on laptops... So these things needs doing as well IMHO. Just my 2 cents.

_________________
Akita Linux, VLC-GTK, Pup Search, Pup File Search
Back to top
View user's profile Send private message 
Flash
Official Dog Handler


Joined: 04 May 2005
Posts: 10662
Location: Arizona USA

PostPosted: Sat 12 Mar 2011, 09:03    Post subject:  

sc0ttman wrote:
...Another issue I thought of... I have ROX desktop using double click for icons. If you single click on an icon, it is highlighted with the translucent mask. But how would we add the feature of clicking on the desktop (not on another icon) to remove focus from the highlighted desktop icon?

If I click in the ROX window between two files or directories, the highlight mask goes away from the file or directory I had highlighted. It's hard to find the dead area Smile . It seems to help if I'm using ROX's "Extra details" view and move the cursor over to the middle or right side.

Quote:
Also, if you have double click enabled for ROX file manager navigation as well, you will see that when you click once on a file/folder (to select it), holding shift and using the cursor keys does not make ROX highlight the next or previous files - you cannot use the keyboard to highlight multiple files.

I personally like using the keyboard, especially on laptops... So these things needs doing as well IMHO. Just my 2 cents.

I agree. Sometimes the keyboard is better than the cursor. Smile
Back to top
View user's profile Send private message 
sc0ttman


Joined: 16 Sep 2009
Posts: 2363
Location: UK

PostPosted: Sat 12 Mar 2011, 11:03    Post subject:  

Flash wrote:
sc0ttman wrote:
...Another issue I thought of... I have ROX desktop using double click for icons. If you single click on an icon, it is highlighted with the translucent mask. But how would we add the feature of clicking on the desktop (not on another icon) to remove focus from the highlighted desktop icon?

If I click in the ROX window between two files or directories, the highlight mask goes away from the file or directory I had highlighted. It's hard to find the dead area Smile . It seems to help if I'm using ROX's "Extra details" view and move the cursor over to the middle or right side.

Sorry, but here I was actually referring to the desktop icons created by the ROX pinboard, not the file manager. I have no problem de-selecting things in the file manager (just to be clear)

_________________
Akita Linux, VLC-GTK, Pup Search, Pup File Search
Back to top
View user's profile Send private message 
Dougal


Joined: 19 Oct 2005
Posts: 2505
Location: Hell more grotesque than any medieval woodcut

PostPosted: Sat 12 Mar 2011, 16:43    Post subject:  

Makoto wrote:
Hmm... is there, perhaps, an easier way of selecting a large group of files without Ctrl-clicking (or middle-mouse button-clicking) on each file, one by one... or in those rare instances when I'm at the end of the list and can draw a rectangle around the files?

Well, you could look at the docs to see if there's another fancy way (rox has heaps of nice features), but there are a few I use:
- Ctrl-A... if you don't want all, just un-select the ones you don't want (the spacebar makes this pretty easy).
- Select the few you don't want and invert the selection...
- If you want all the files with the same extension, use the "." feature: for all .html files, just type ".html" and they'll get selected.
- Use the "?" feature: if you want all the files with a name starting with "pup", type ? and then
Code:
'pup*'
(the quotes are important)
A more complicated example: you have a directory with files named 01 02 ... 40 and want only 20-40, so you type ? and then
Code:
'[234][0-9]'

For 25-40, type ? and then
Code:
'2[5-9]', '[34][0-9]'


But in many cases just pressing the spacebar for a few seconds is the fastest way... what do you need but a spacebar and four arrow keys?

Note another nice trick rox has (appears under "Saving and restoring the selection" in the manual): if you go to a certain directory a lot, when you are in that directory you just need to type Ctrl+<number> and that directory will be remembered by that number, like a simple bookmark.
Example: go to /usr/share/doc, then press Ctrl+1 -- afterwards every time you press "1" it will jump to /usr/share/doc!

_________________
What's the ugliest part of your body?
Some say your nose
Some say your toes
But I think it's your mind
Back to top
View user's profile Send private message 
Dougal


Joined: 19 Oct 2005
Posts: 2505
Location: Hell more grotesque than any medieval woodcut

PostPosted: Sat 12 Mar 2011, 16:46    Post subject:  

sc0ttman wrote:
Another issue I thought of... I have ROX desktop using double click for icons. If you single click on an icon, it is highlighted with the translucent mask. But how would we add the feature of clicking on the desktop (not on another icon) to remove focus from the highlighted desktop icon?

The best solution would be to cure yourself from the MS disease... double-clicking, I mean, not Multiple Sclerosis...
As for what to do with rox, the question is how rox actually behaves in double-click mode: can you highlight a few icons and then move them, like in Windows?
If not, then you don't want the highlighting at all, in which case you just make the draw_wink function to check if you're in double-click mode and, if so, do nothing.
If it does, you probably want to add something to forward_to_root() to make it unselect the selected icons.


Quote:
Also, if you have double click enabled for ROX file manager navigation as well, you will see that when you click once on a file/folder (to select it), holding shift and using the cursor keys does not make ROX highlight the next or previous files - you cannot use the keyboard to highlight multiple files.

I don't know about this, you need to look in the relevant part of the code...

_________________
What's the ugliest part of your body?
Some say your nose
Some say your toes
But I think it's your mind
Back to top
View user's profile Send private message 
Makoto


Joined: 03 Sep 2009
Posts: 1722
Location: Out wandering... maybe.

PostPosted: Sat 12 Mar 2011, 19:26    Post subject:  

Dougal wrote:
Well, you could look at the docs to see if there's another fancy way (rox has heaps of nice features), but there are a few I use:
- Ctrl-A... if you don't want all, just un-select the ones you don't want (the spacebar makes this pretty easy).


Yeah, but in the hypothetical example I had in my mind, there were 1,000 files in a directory, and I'd want to select 200 of them, from somewhere in the middle. Razz

I didn't know you could use the spacebar like that, though. (Tested it a moment ago.) I've learned something new, today. Smile

Quote:
- Select the few you don't want and invert the selection...
- If you want all the files with the same extension, use the "." feature: for all .html files, just type ".html" and they'll get selected.


Hmm... didn't know about that one, either.

Quote:
But in many cases just pressing the spacebar for a few seconds is the fastest way... what do you need but a spacebar and four arrow keys?


Enter, maybe? Or Ctrl/Alt for the occasional alternate option. Smile

Heh, I'm definitely one of the older veterans used to doing almost everything via the keyboard. Very Happy

Thanks!

Edit: As for double-clicking/the "MS disease," I have ROX set to double-click as well, but that's mainly because I want to avoid accidentally executing something (every once in a while I might accidentally get a little heavy-handed and left-click the mouse on something when I didn't mean to, for example).

_________________
[ Puppy 4.3.1 JP, Frugal install | 1GB RAM | 1.3GB swap ] * My Pidgin Builds for Puppy 4.3.1+
In memory of our beloved American Eskimo puppy (1995-2010) and black Lab puppy (1997-2011).
Back to top
View user's profile Send private message 
Puppyt

Joined: 09 May 2008
Posts: 550
Location: Karana Downs, Queensland

PostPosted: Wed 16 Mar 2011, 07:03    Post subject:  

Rather than go to the trouble of adding a tree-like graphical interface for ROX's file management, and taking Konquerer's lead I was thinking that perhaps add-ons might already exist in Dillo or SeaMonkey to fill the gap. Then I found one for FireFox: "Firefly" (https://addons.mozilla.org/en-us/firefox/addon/firefly/) - though it hasn't been updated for years and gets mixed reviews.

In my wildest imagination I picture a Puppy user opening ROX and thinking "Damn - now I need trees", and just dragging the ROX window either onto a browser icon or into an open browser. The file tree for that given location might be highlighted in an automatically-generated new page, providing the the user the opportunity to view and re-organize files within a single window, external to ROX and using the existing functionality of the browser.

Maybe something that fancy is implausible- but at least an "Explorer" or "Navigator" function for Puppy's Dillo or Pupbrowser would be sweet. Is the idea possible, plausible, or just plain fantasy?

_________________
Toowoomba Linux Community
http://groups.google.com/group/toowoombalinux
Back to top
View user's profile Send private message Visit poster's website 
technosaurus


Joined: 18 May 2008
Posts: 4134

PostPosted: Fri 18 Mar 2011, 16:15    Post subject:  

I still like the gtk1 version of rox ... a couple more backports like the ones amigo did and it would be great and only 1/3 the weight
_________________
Web Programming - Pet Packaging 100 & 101
Back to top
View user's profile Send private message 
Flash
Official Dog Handler


Joined: 04 May 2005
Posts: 10662
Location: Arizona USA

PostPosted: Sat 02 Jul 2011, 23:35    Post subject:  

Where can I find this gtk1 version of ROX? Would it work in Lucid 245? I'd like to try it to see if it copies files inside a directory in numerical order of filename. Presently, when I drag an mp3 book directory containing several hundred mp3 files to my mp3 player, the files in the directory are copied in some weird order, not in the order of their filenames as you would expect.
Back to top
View user's profile Send private message 
disciple

Joined: 20 May 2006
Posts: 6378
Location: Auckland, New Zealand

PostPosted: Sun 03 Jul 2011, 05:31    Post subject:  

Flash wrote:
Where can I find this gtk1 version of ROX?

In the Puppy 2.x repository, which was still alive last time I looked. You might want to build Amigo's latest version instead though.
Quote:
Would it work in Lucid 245?

Yes - it would also need the libgtk12 and libgdk12 packages or whatever they are called.

_________________
DEATH TO SPREADSHEETS
- - -
Classic Puppy quotes
- - -
Beware the demented serfers!
Back to top
View user's profile Send private message 
Display posts from previous:   Sort by:   
Page 2 of 4 [46 Posts]   Goto page: Previous 1, 2, 3, 4 Next
Post new topic   Reply to topic View previous topic :: View next topic
 Forum index » Advanced Topics » Puppy Projects
Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Powered by phpBB © 2001, 2005 phpBB Group
[ Time: 0.1310s ][ Queries: 13 (0.0289s) ][ GZIP on ]