pMusic 6.0.0

[Iguleder]

zigbert: I'll play with it, I think I'll to make some bash wrapper for the tray icon. In the current mode, this is how it works:

pmusic -> tray icon

I'll change it:

pmusic -> icon wrapper -> tray icon

A bash wrapper is the easiest way to check whether the GUI is running or not, by using ps and grep on "pmusic -b" or whatever it was, don't remember.

- Why do you use xpm-icon, when png is supported. I have linked the xpm-file to pmusic20.png

I tried PNG, it didn't work ... I'll change that

- pmusic -b shows trayapp, but at first click it will hide gui which is not yet there. Is it possible to check this somehow?

As I said, a wrapper which checks whether pmusic runs in the background or not and tells the tray icon what to do. I can make the tray icon run with a parameter, if it's "0" it starts with showing, otherwise it starts with hiding as the action performed when you first click on it.

- Is it possible to make a right-click-menu for next and previous song. Pmusic 1.0.3 now includes the -s switch (signal), and at this point you can send 'next' and 'prev' to navigate a running Pmusic. more signals is described with pmusic -h

I'll try to learn how to do popup menus in GTK ... don't worry

- What about controlling hotkeys with pmusic_tray

Should be possible.

- $HOME/.pmusic/tmp/ffmpeg_NOW_PLAYING shows playing song. and might be used as info.

I'll do a tooltip maybe, with the current song and the action performed when you click the icon, something like: "Now playing: roflzomg by lolman, click to hide Pmusic".

[don570]

I tested pmusic 103 on lucid puppy 504 and there
was one feature that didn't work at all.
'Hide GUI' just launched another nameless app
that wasted valuable tray space.
Also I noticed that Puppy Package Manager didn't
show pmusic on it's list, so I couldn't uninstall it
apparently.

The feature had worked right when I used pmusic102
if I installed Iguleder's package pmusic_tray-1.0.2-lupu.pet
that I got from this thread.
There was just one icon on the right hand side of tray.
So no space was wasted and it was easy to use.


On the bright side the feature 'Show location' works
perfectly! Your motto should be 'Better than an Apple'

[don570]

These are some dumb questions that I'm sure have been asked before.

How does the user know that he has reached the maximum size of an
Audio disc before launching pburn? In other words, a playlist of 80 minutes.

Isn't there any limits to the number of file names on the 'most recently played'
and 'most played' lists?
I had so many on list because of my testing of program that I had to delete the
two relevant preferences files. That fixed the problem.

[zigbert]

I tested pmusic 103 on lucid puppy 504 and there
was one feature that didn't work at all.
'Hide GUI' just launched another nameless app
that wasted valuable tray space.
Also I noticed that Puppy Package Manager didn't
show pmusic on it's list, so I couldn't uninstall it
apparently.

I will test Pmusic in Puppy 5.1.......

Your motto should be 'Better than an Apple'

What about
Pmusic - doesn't taste like apple


Sigmund

[zigbert]

How does the user know that he has reached the maximum size of an Audio disc before launching pburn? In other words, a playlist of 80 minutes.

You can't, but Pburn shows length, so you can easily modify the list before burning. On the other hand, it is not science to calculate the length of the playlist........ How do you think it should be included. - Where to click or show up.

Isn't there any limits to the number of file names on the 'most recently played' and 'most played' lists?
I had so many on list because of my testing of program that I had to delete the
two relevant preferences files. That fixed the problem.

There is a limit. Maybe 2000, I don't remember....... But what is the exact problem you refer to? I don't see the problem of storing these song-names. Does it affect stability or speed?


Sigmund

[zigbert]

I have checked: The number of recent/most played is 1000

Be aware the you can clear the 'most played' db (file) from the preferences dialog


Sigmund

[zigbert]

don570
I fired up lupu506, and installed Pmusic 1.0.3. The 'Hide Gui' function worked as supposed??????


Sigmund

[don570]

I have downloaded the new lupu 506 and I will test
pmusic 103 on it tonight. I always use a frugal install.

______________________________________

As far as the total time of a playlist is concerned, some
people aren't very bright and can't add a list of numbers.
So the rest of us must think about there wants and needs.
I vote to put the total time near the bottom of the playlist, however
it may be easier for you to put it at the head. It's all the same really.

___________________________________________
If I remember correctly I didn't like the long list of recently played
when I was checking out how 'Bookmarks' worked. I forget why.
I'll check that out again tonite.

[Iguleder]

zigbert, here's a new tray icon with most of the stuff you asked for.

I had to edit func, I added two lines to the -quit function:

Code: Select all

-quit)
	#end all processes
	. $APPDIR/func -update_playlist
	echo end > $WORKDIR/end_while
	echo end > $WORKDIR/end_while_add
	for I in `ps | grep Pmusic | grep gtkdialog | awk '{print $1}'`; do kill -9 $I 2> /dev/null; done
	for I in `ps | grep -i pmusic | grep index | awk '{print $1}'`; do kill -9 $I 2> /dev/null; done
	for I in `ps | grep aplay | awk '{print $1}'`; do kill -9 $I 2> /dev/null; done
	for I in `ps | grep pmusic | grep playing | awk '{print $1}'`; do kill -9 $I 2> /dev/null; done
	killall pmusic_tray_bin > /dev/null 2>&1  <===
	rm /tmp/.pmusic_tray > /dev/null 2>&1 <===
	exit 0
	;;

Here's a new tray icon (compile and put in /usr/bin/pmusic_tray_bin):

Code: Select all

/*Simple Pmusic tray icon 003 by Iguleder
 * Based on the tray icon skeleton by Barry Kauler*/

#include <string.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <gtk/gtk.h>
#include <gdk/gdk.h>
#include <gdk/gdkkeysyms.h>
#include <glib/gstdio.h>

GdkPixbuf *pmusic_pixbuf;
GError *gerror;

//1 if Pmusic GUI is running, otherwise 0
int running=1;

void play_next (GtkWidget *tray_icon, gpointer userdata)
{

	system("pmusic -s next &");

}

void play_previous (GtkWidget *tray_icon, gpointer userdata)
{

	system("pmusic -s prev &");
	
}

void quit_pmusic (GtkWidget *tray_icon, gpointer userdata)
{

	system("pmusic -q");

}

void view_popup_menu (GtkWidget *tray_icon, GdkEventButton *event, gpointer userdata)
{

	GtkWidget *menu, *menuitem1, *menuitem2, *menuitem3;

	menu = gtk_menu_new();

	menuitem1 = gtk_menu_item_new_with_label("Next track");
	menuitem2 = gtk_menu_item_new_with_label("Previous track");
    menuitem3 = gtk_menu_item_new_with_label("Quit Pmusic");
    
	g_signal_connect(menuitem1, "activate", (GCallback) play_next, tray_icon);                 
	g_signal_connect(menuitem2, "activate", (GCallback) play_previous, tray_icon);
	g_signal_connect(menuitem3, "activate", (GCallback) quit_pmusic, tray_icon);
                       
	gtk_menu_shell_append(GTK_MENU_SHELL(menu), menuitem1);
	gtk_menu_shell_append(GTK_MENU_SHELL(menu), menuitem2);
	gtk_menu_shell_append(GTK_MENU_SHELL(menu), menuitem3);
	
	gtk_widget_show_all(menu);

	gtk_menu_popup(GTK_MENU(menu), NULL, NULL, NULL, NULL, (event != NULL) ? event->button : 0, gdk_event_get_time((GdkEvent*)event));

}

gboolean view_onPopupMenu (GtkWidget *tray_icon, gpointer userdata)
{

	view_popup_menu(tray_icon, NULL, userdata);

	return TRUE; /* we handled this */
	
}

void tray_icon_on_click(GtkStatusIcon *tray_icon, gpointer user_data)
{
	
	if (running == 0)
	{
		system("pmusic &");
		running=1;
		gtk_status_icon_set_tooltip(tray_icon, "Click to hide Pmusic");
	}
	else
	{
		system("pmusic -b &");
		running=0;
		gtk_status_icon_set_tooltip(tray_icon, "Click to show Pmusic");
	}
	
}

static GtkStatusIcon *create_tray_icon() 
{

	GtkStatusIcon *tray_icon;

	tray_icon = gtk_status_icon_new();
        
	g_signal_connect(G_OBJECT(tray_icon), "activate", G_CALLBACK(tray_icon_on_click), NULL);

	g_signal_connect(G_OBJECT(tray_icon), "popup-menu", (GCallback) view_onPopupMenu, NULL);

	pmusic_pixbuf=gdk_pixbuf_new_from_file("/usr/local/pmusic/pmusic20.png",&gerror);
	gtk_status_icon_set_from_pixbuf(tray_icon,pmusic_pixbuf); 
     
	gtk_status_icon_set_tooltip(tray_icon, "Click to hide Pmusic");    
                                              
	gtk_status_icon_set_visible(tray_icon, TRUE);
       
	return tray_icon;
}

int main(int argc, char **argv) 
{

	GtkStatusIcon *tray_icon;

	gtk_init(&argc, &argv);
	tray_icon = create_tray_icon();
	gtk_main();

	return 0;
	
}

And here's a wrapper for the tray icon:

Code: Select all

#!/bin/ash

if [ ! -f /tmp/.pmusic_tray ]; then

  touch /tmp/.pmusic_tray
  pmusic_tray_bin &
  exit 0
  
else

  exit 1

fi

In order to start the tray icon, all you need is the command pmusic_tray, it makes sure there's only one instance with a temporary lock file, /tmp/.pmusic_tray. The addition to func deletes that file to make sure the icon runs the next time you start Pmusic.

Other cool stuff:
- Next/previous on a popup menu, I haven't tested it because I was unable to download 1.0.3.
- An option to exit on the popup menu.
- Cleaner code.
- Uses pmusic20.png by default, looks better and saves a symlink

I have no idea how you integrated it into Pmusic (again, the mirror is down), so maybe something needs to be changed. I think you should make the tray icon a separate package and make Pmusic check whether it is installed with "which pmusic_tray". If it isn't, the tray icon option is disabled.

[don570]

I tested Pmusic on various versions of Puppy Linux that I had on hard disk(frugal install)
I found out the hard way that I needed to test without a pupsave to get consistent results.
I was able to track down the problem because I noted closely the installer message.
This message always said that there would be no menu entry when of course the message should
say that there will be a menu entry.
Here is the results of my testing:

spup0.4 works fine except for installer message
lupu 506 works fine except for installer message
lupu 505 works fine except for installer message
luci 209 works fine except for installer message
luci 212 works fine except for installer message
luci 213 works fine except for installer message
Lighthouse Puppy 4.43 requires menu to be 'refreshed' to make pmusic show on start menu, then it worked fine.
Lighthouse Puppy 5c also required menu to be 'refreshed' but it had an irritating flaw that prevented it
from working as desired. A small window announcing Pmusic showed
instead(click on name to obtain picture)
[img][img=http://upmyphoto.com/img/thumbnails/frh_720100_images_3075_29153442000000_19686779201597_loc.jpg][/img]
Finally lupu 503 which was by chance the first installation that I tested,and it had a huge flaw. It wouldn't
install in tray.The red dot icon was a very small window instead and the tray contained
a mysterious red X (click on name to obtain picture)
[img][img=http://upmyphoto.com/img/thumbnails/frh_720105_images_3075_29153007000000_15044889892863_loc.jpg][/img]

I spent hours on this. My first observation was that your package was working correctly
on most versions of puppy however I did notice something strange,
namely that the installer program said that there would be no menu entry. Also both versions of
Lighthouse do not have Pmusic pre-installed. I realized that that was why they required a refreshing
of the menu. That made me look at the desktop file of you pet package
but I didn't notice anything wrong.
I continued to make changes in you package until I hit upon the solution.

I traced the problem down to a faulty pet.specs file in your pet package.
Here is your pet.specs file

Code: Select all

pfilesearch-1.22|pfilesearch|1.22||BuildingBlock|80K|pet_packages-4|pfilesearch-1.22.pet||file finder engine|||official|

And here is the new pet.specs that was generated after I removed your faulty pet.specs file and when I made a pet package with the command 'dir2pet'

Code: Select all

pmusic-1.0.3|pmusic|1.0.3||Multimedia|364K||pmusic-1.0.3.pet||audio player|slackware|13.1||

You'll notice quite a difference. It's a miracle that your package worked as well as it did.
The puppy installer became confused when installing your pet package.
That's why when I ran PPM, pmusic never came up as an application that had been installed.

So the solution is simple. Remove the bad pet.specs file
and make the package all over again. This will generate a new pet.specs file.
I rechecked the repaired pet package on spup,Lighthouse puppy 5c and lupu 503 and lupu505
They all worked perfectly amd the installer message is now correct as well!
I also came across a solution for the problem with Lighthouse Puppy 5. First install pmusic 102
and refresh menu to get pmusic to show up on start menu. Then install pmusic 103 and refresh the menu.
Everything will now work fine.

[zigbert]

don570
Wow!!!!



You are great !!!

I am working on the next release, and be sure; I will make a new pet.spec file


Sigmund

[don570]

There is a small quirk in pmusic I came across.
Pmusic saves it's window HEIGHT and WIDTH and it is reset
when clicking on right hand corner X i.e. the close box.
But it should also be reset when Quit is chosen from menu
which it is not.

[don570]

I was thinking about what disturbed me about the recently played list
and I remember testing a lot of sound files named after 2barks.wav.
So the recently played list had a large number and variations of the name
on the list and that irritated me. So I just deleted the file. No big deal.

___________________________________________________________

As far as Total Playing Time of playlist, I see that there is no space
in the classic mode for this feature, but there still is the possibility
of a menu item isn't there?
.... and that would be nearly as good. I would suggest 'Playlist time'
'Total Time' or even 'Add Total Time' for the menu item.

___________________________________________________________

[zigbert]

There is a small quirk in pmusic I came across.
Pmusic saves it's window HEIGHT and WIDTH and it is reset
when clicking on right hand corner X i.e. the close box.
But it should also be reset when Quit is chosen from menu
which it is not.

Fixed for next release!!

thanks
Sigmund

[zigbert]

As far as Total Playing Time of playlist, I see that there is no space in the classic mode for this feature, but there still is the possibility
of a menu item isn't there?

guess so

The changelog is getting longer each day, so I think we will go for pmusic-1.1.0 next. There is still one hard feature to implement before ready....... Are you looking at the faq? - Else, I have to put my dirty fingers on it........If you feel like it, - please help.


Sigmund

[don570]

I was doing a lot more testing. and I've found more problems
with special characters. I'll document this in next post.
I didn't want to submit anything without proper testing
but since you're in a rush here's my effort. You will
have to change it . I'm sure there is inaccuracies.

Some points to be reviewed :
What is a podcast? I don't know how it's done in linux. I only used
Apple itunes. and it was simple.

What command is used to open a playlist
pmusic playlist.m3u
or pmusic -a playlist.m3u

Does pburn support a full 80 minute burn of playlist or is there
some restrictions. You should explain that. I was going to test that
but then I discovered the problems with special characters, in
particular the backtick`

Code: Select all

Q: What are Bookmarks and how do I use them?
A: 'Bookmarks' is an advanced feature to help the user to quickly
find a source of music i.e. a large number of music files stored somewhere
on your hard disk. To use a bookmark is fairly simple. You must use the menu heading
'Music-sources' and choose 'Bookmarks'. The list will appear. You click only once on a 
Bookmark, then click on the magnifying glass.  The Pmusic file management system kicks in. 
 
Extra note: At the top of the Bookmark list is the name 'Manage Bookmarks'. 
It isn't a source of music.  See next question to find out what it does.

Q:  But how do I make a new Bookmark? 
A:  Click once on 'Manage Bookmarks'  As an example, let's say that /root/Music is the location
of a large number of songs.  Click once on the small icon next to Path/URL field.  Add the folder
you wish. Back in the 'Manage Bookmarks' window, the path to folder is at the top. Type in a simple 
descriptive name in the field directly beneath the path to folder. Click once on the blue plus symbol. 
Then click on the OK button to get out of  the 'Manage Bookmarks' window. Unfortunately you 
will not see this new Bookmark on the list immediately, but if you switch your mode, let's say 
from 'Manger' to 'Wings' then the list is updated. Check this to be sure.

Q: What are Podcasts?
When you sign up for a podcast, you get regular file downloads automatically, maybe even once a day.
As an example Deutsche Welle has a free daily podcast called  'Langsam gesprochene Nachrichten'
to help students learning German.
Make sure you select mp3 as the file format of the podcast if possible ,since 
this is the most popular song format and very compact.  Create the folder /root/my-documents/Podcasts.  
You tell the podcaster to send the the podcasts automatically to this folder.  The folder is on 
your list of Bookmarks so it is easy locate.  Tip:  Have one Playlist just for Podcasts alone.

Q:  I have a folder full of podcasts. How do I rename it 'Podcasts'.
A:  Very simple.  Go to menu item 'Preferences' and under 'Playlist' the name of a playlist
can be easily changed. Insert the name 'Podcasts'. 

Q: What file operations are possible?
A:  Once a song is playing you can do several operations.  'Rename' 'Copy' or 'Delete' are available 
under menu heading 'Playlist'  You will be given a warning when you delete, but beware 'delete' 
means the erasing of the file so it is gone forever. For powerful file management you should try under 
the Tools menu,  'Rox-Show location...'.  The Rox-filer will pop up a folder window with the song 
that is currently playing or has just finished playing.

Q: I want my window to be wider to see all the info, but how do I do this permanently?
A: Set the window dimensions to be right for your screen (using mouse drag of bottom right corner). 
Then click the close box which is usually the upper right hand X. Pmusic will set the values for height
and width in it's configuration file /root/.pmusic/pmusicrc. The next time pmusic is launched 
it will use these new values.

Q: What if I want to convert a WAV file to a MP3 file?
A: If you have a large number of files to convert located in one folder,
I would suggest installing  paudioscripts-1.4.2.pet, which is a collection 
of scripts that will create a folder and place the converted files in this folder.  
The script I use is wav2mp3. There is also another script that converts MP3 to WAV
called mp32wav. If you have a playlist to convert then use Pmusic. 
Under Tools menu choose 'copy/convert'. Click 'Specify output stream'.  
For high quality stereo conversion choose 192000 bits/sec. 
For mono songs you choose half the stereo rate. 

Q:  How do I burn a playlist to an audio disc?
A:  Pmusic is well matched with the program Pburn. Once you have a playlist(well under 80 minutes long)
of WAV,MP3,OGG,WMA files, then choose menu item 'Burn files in playlist' . 
When Pburn is first run, it will ask you where it should store it's temporary files. 
It will warn you not to select a partition that is formated in FAT(an old Microsoft standard). 
The other types of file system formatting such as ext2/3 and ntfs are fine. 
Make sure that there is at least 800mb (minimum) of empty space available on this drive.
Choose the 'normalize' option in Pburn since it adds only a small amount of extra time to burn process.
Follow instructions and in only a few minutes you will have burnt an audio disk.  Keep the disk in
a sleeve, out of sunlight, and it should last for many years.

Q: Can I use the terminal to add files to a playlist?
A: Yes, but why do it the hard way when there are easier methods available. Namely, the built-in file 
management system of Pmusic (called a file browser) or alternatively Rox Filer will add files to the 
current playlist. This was described previously.

Q: My 'Recently Played' and 'Most played' song lists have songs that I have burnt and deleted.  
What should I do?
A: Look under Preferences>Add and you will see an option to delete the 'most played list' 
and Pmusic will create a new list automatically. As far as the list of most recently played, 
there is little need to modify that list.

Q: What happens if the hard disk where my music is located isn't mounted?
A:  It will appear as if the song is playing. The message that the file is 'buffering' will
appear, however no sound will come out of your speakers. Pmusic 1.04 or greater will have a 
preference setting so that the user will be warned at the time of launching Pmusic that 
a hard disk isn't mounted. By the way a simple left click on a drive icon on the desktop will 
mount it using Rox Filer. A green dot on a drive icon means it's mounted.
________________________________________________________________________________________
Known bugs:
1) On rare occasions Pmusic won't play at all. It appears to lock up. This may have been caused 
by the file being renamed or deleted by another program or the square bracket [ character.  
You could try the history feature.  
Another suggestion. Replace this bad playlist with a good one. Using Rox Filer open a playlist 
that has already been saved properly to disk.  The playlist will have an extension .m3u .
You should have set up Rox Filer to automatically open files with this extension in Pmusic.
If you haven't then it's time you did. Using Rox Filer just left click a file with the extension .m3u .
Then choose 'Set Run Action' . The command to be used is 'pmusic "$@"' . Then click the button 
'Use Command'. Now using Rox Filer, one click on a file with the extenson .m3u will open it with 
Pmusic.

2) Pmusic is a 'one click app' which means that the user should only click once on a item.
Clicking twice will cause strange behavior in some situations.

3) Pmusic should play fine even if a song title has special characters in it, however there is three
special characters that you should avoid using. Namely the piping symbol | , th square bracket [
and the backslash \ .  As well  the forward slash is forbidden in linux filenames 
because it is needed to describe the path.

[don570]

I wanted to burn a disk to test out that feature
and I wanted to test the conversion to mp3 feature...
but what do you know, I stumbled upon the old
problem with the backtick ` character all over again.
No wonder I have so much trouble testing Pmusic
when so many of my files have the backtick character `
Here's an example of what I did and the problems it creates:


I saved two playlists and then tried opening them up again.
The file with special characters would show only one or two songs when
it was re-opened,whereas the playlist file without special characters
would show all its song names on the playlist fine

Code: Select all

/mnt/sda5/don/Music/dvorjak#7-davis!`.wav
/mnt/sda5/don/Music/schubert#9-excerpt-rattle!`.wav
/mnt/sda5/don/Music/grieg-symphonic_dance-gothenberg!`.wav
/mnt/sda5/don/Music/mozart-haffner-mackeras!`.wav

Code: Select all

/mnt/sda5/don/Music/harry_manx766587757.wav
/mnt/sda5/don/Music/reggae-piano76t8.wav
/mnt/sda5/don/Music/Dabatay657r7-cora.wav
/mnt/sda5/don/Music/ama_kundo878.wav

The obvious difference is that one list uses special characters whereas the other does not.
After testing I'm pretty sure that this is the old backtick ` problem.


As well I found that the Tools>'Copy/Convert files in playlist' menu item won't
convert if a backtick is in filename. I couldn't convert schubert#9-excerpt-rattle!`.wav to a MP3 file.

_______________________________________________________

And the problem isn't confined to the backtick character.
I did a quick test of the asterisk *.
I was able to convert schubert#9-excerpt-rattle*.wav to
schubert#9-excerpt-rattle*.mp3
I made a new playlist and put schubert#9-excerpt-rattle*.mp3 on the list. It worked
but when I tried right click to get the name off the list, it wouldn't disappear.
In an emergency I can still use the history feature to get to a previous playlist. I realized that the asterisk was causing the file to 'stick' permanently to a playlist.
I did more testing and I can definitely say that the asterisk causes 'sticking' in the
playlist.

I suspect the square bracket is another character [ that will give problems,
but I haven't had time to test.

[zigbert]

don570
Great stuff, I have started to build a more advanced html document to handle bigger amount of information.

First I will work on the faq, then you can verify it while I look at your bug-report. But what is VERY important: Let there NEVER be any kind of rush Longterm support of opensource projects require a non-stress environment. We have too many uncontinued projects in the Puppy community.....

Do you want to share your full name. - I want to include you to the 'credits'.


Thanks for your work
Sigmund

[zigbert]

Here is a draft of the faq.

I didn't include
'What happens if the hard disk where my music is located isn't mounted? '
It should be self-explained in the next release.


Sigmund

[zigbert]

don570
Regarding your problem with burning/converting files with special characters in filename, be aware that ffmpeg have trouble with some non-english chars. I don't know if this is because of the compile in Puppy 4.3.1, an older version of ffmpeg, or that ffmpeg troubles in general with this issue.

Pmusic fails with files with # in name. - Both when moving and removing
I will look at it.


Sigmund